Daniel D’Aquino e951370a76 Fix relay URL trailing slash issues
This commit tries to replace all usage of `String` to represent relay
URLs and use `RelayURL` which automatically converts strings to a
canonical relay URL format that is more reliable and avoids issues related to
trailing slashes.

Test 1: Main issue fix
-----------------------

PASS

Device: iPhone 15 Simulator
iOS: 17.4
Damus: This commit
Steps:
1. Delete all connected relays
2. Add `wss://relay.damus.io/` (with the trailing slash) to the relay list
3. Try to post. Post should succeed. PASS
4. Try removing this newly added relay. Relay should be removed successfully. PASS

Test 2: Persistent relay list after upgrade
--------------------------------------------

PASS

Device: iPhone 15 Simulator
iOS: 17.4
Damus: 1.8 (1) `247f313b` + This commit
Steps:
1. Downgrade to old version
2. Add some relays to the list, some without a trailing slash, some with
3. Upgrade to this commit
4. All relays added in step 2 should still be there, and ones with a trailing slash should have been corrected to remove the trailing slash

Test 3: Miscellaneous regression tests
--------------------------------------

Device: iPhone 15 Simulator
iOS: 17.4
Damus: This commit
Coverage:
1. Posting works
2. Search works
3. Relay connection status works
4. Adding relays work
5. Removing relays work
6. Adding relay with trailing slashes works (it fixes itself to remove the trailing slash)
7. Adding relays with different paths works (e.g. wss://yabu.me/v1 and wss://yabu.me/v2)
8. Adding duplicate relay (but with trailing slash) gets rejected as expected
9. Relay details page works. All items on that view loads correctly
10. Relay logs work
11. Getting follower counts and seeing follow lists on profiles still work
12. Relay list changes persist after app restart
13. Notifications view still work
14. Copying the user's pubkey and profile link works
15. Share note + copy link button still works
16. Connecting NWC wallet works
17. One-tap zaps work
18. Onboarding works
19. Unit tests all passing

Closes: https://github.com/damus-io/damus/issues/2072
Changelog-Fixed: Fix bug that would cause connection issues with relays defined with a trailing slash URL, and an inability to delete them.
Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
Signed-off-by: William Casarin <jb55@jb55.com>
2024-03-25 09:24:17 +01:00
2024-03-25 09:24:17 +01:00
2024-01-16 16:55:24 -08:00
2024-03-22 10:15:00 +01:00
2024-03-17 08:54:35 +00:00
2024-02-28 23:56:13 -08:00
2024-03-13 10:06:01 -05:00

Run Test Suite

damus

A twitter-like nostr client for iPhone, iPad and MacOS.

How is Damus better than twitter?

There are no toxic algorithms.
You can send or receive zaps (satoshis) without asking for permission.
There is no central database. Therefore, Damus is censorship resistant.
There are no ads.
You don't have to reveal sensitive personal information to sign up.
No email is required.
No phone number is required.
Damus is free and open source software.
There is no Big Tech moat. Therefore, seamless interoperability with thousands or millions of other nostr apps is possible, and is how Damus and nostr win.

If there are no ads, how is Damus funded?

Damus offers a paid subscription 🟣 purple 🟣 https://damus.io/purple/.
Initial benefits include a unique subscriber number, subscriber badge, and auto-translate powered by DeepL.

Damus has also graciously received donations or grants from hundreds of Damus users, Opensats, and the Human Rights Foundation.

Spec Compliance

damus implements the following Nostr Implementation Possibilities

Getting Started on Damus

Damus iOS

  1. Get the Damus app on the iOS App Store: https://apps.apple.com/ca/app/damus/id1628663131

⚙️ Settings (gear icon, top right)

  • Relays: You can add more relays to send your notes to by tapping the "+".
  • Public Key (pubkey): Your public, personal address and how people can find and tag you
  • Secret Key: Your private key unique to you. Never share your private key publicly and share with other clients at your own risk!
    • Save your keys somewhere safe
  • Log out

🏠 Personal Feed (home icon, bottom navigation)

  • Feed from everyone you follow
  • Can post notes by tapping the blue + button

Notes (under 🏠 Personal Feed)

  • Sending a Note is easy and it goes to both your 🏠 Personal and 🔍 Global Feeds
  • To tag a user you must grab their pubkey:
    1. Search their username in the search bar at the top of the 🔍 Global Feed and click their profile
    2. Tap the 🔑 icon which will copy their pubkey to your clipboard
    3. Go back to your 🏠 Personal Feed and tap the blue + button to compose your Note
    4. Add @ directly followed by the pubkey (e.g., @npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s)
  • You can also tap the ellipsis menu of a Note (three dots in top right of note) to grab their User ID aka pubkey or Note ID to link directly to a Note.
  • Currently you can't delete your Notes in the iOS app
  • Share images by pasting the image url which you can grab from nostr.build, imgbb, imgur, etc. (i.e., https://i.ibb.co/2SHZbwm/alpha60.jpg). Currently images only load for people you follow in the 🏠 Personal Feed. Images are not automatically loaded in 🔍 Global Feed
  • Engaging with Notes
    • 💬 Replying to a Note: Tap the chat icon underneath the note. This will show up in the users notifications and in your 🏠 Personal and 🔍 Global Feeds
    • ♺ Reposts: Tap the repost icon which will show up in your 🏠 Personal and 🔍 Global Feeds
    • ♡ Likes: Tap the heart icon. Users will not get a notification, and cannot see who liked their note (currently, web clients can see your pfp only)

💬 Encrypted DMs (chat app, bottom navigation)

  • Tap the chat icon and you'll notice there's nothing to see at first. Go to a user profile and tap the 💬 chat icon next to the follow button to begin a DM

🔍 Global Feed (magnify glass, bottom navigation)

  • View the Global Feed from all the relays you've added in ⚙️ Settings. Currently you can only search hashtags and user names and pubkeys

🔔 Notifications

  • All your notifications except 💬 DMs

👤 Change Your Profile (PFP) and Bio

  1. Go to your Profile Page on Damus app
  2. Tap on Edit button at the top
  3. You will see text fields to update your information and bio
  4. For PFP, insert a URL containing your image (support video: https://cdn.jb55.com/vid/pfp-editor.mp4)
  5. Save

Request Sats

Paste an invoice from your favorite LN wallet. (Sats or Satoshis are the smallest denomination of bitcoin)

Alby (browser extension)

  • Get the Alby browser extension and create your Alby address [yourname]@getalby.com or connect your existing Lightning wallet
  • Convert your Damus secret key from nsec to hex at https://damus.io/key then go to Settings in Alby and under the Nostr section at the bottom of the page add your private hex key. You can also generate new address in the extension
  • Click the Alby extension > click Receive > enter the amount of Sats > click Get Invoice > click Copy > then paste into Damus
  • Note: On Damus Web it will appear as a string of characters but on Damus iOS it will appear as a clickable image

Zeus (mobile app)

  • Download Zeus app (iOS, Google, APK)
  • Tap Get Started button > tap Connect a node > click on + sign (top right) > select Indhub > press Scan Lndhub QR > (from the Alby browser extension… click your account on the top left > click Manage Accounts > click 3-dot menu to right of your account and click Export Account to get a QR code then go back to Zeus app) > scan the QR Code and tap Save Node Config button
  • To create an invoice tap Lightning > tap Receive > type in amount > tap Create Invoice > tap Copy Invoice > paste into a new Damus note

Contributing

Contributors welcome! Start by examining known issues: https://github.com/damus-io/damus/issues.

Mailing lists

We have a few mailing lists that anyone can join to get involved in damus development:

  • dev - development discussions
  • patches - code submission and review
  • product - product discussions
  • design - design discussions

Contributing

See docs/CONTRIBUTING.md

Privacy

Your internet protocol (IP) address is exposed to the relays you connect to, and third party media hosters (e.g. nostr.build, imgur.com, giphy.com, youtube.com etc.) that render on Damus. If you want to improve your privacy, consider utilizing a service that masks your IP address (e.g. a VPN) from trackers online.

The relay also learns which public keys you are requesting, meaning your public key will be tied to your IP address.

It is public information which other profiles (npubs) you are exchanging DMs with. The content of the DMs is encrypted.

Translations

Translators welcome! Join the Transifex project.

All user-facing strings must have a comment in order to provide context to translators. If a SwiftUI component has a comment parameter, use that. Otherwise, wrap your string with NSLocalizedString with the comment field populated.

Awards

Damus lead dev and founder Will awards developers with satoshis! There may be nostr badges awarded for contributors in the future... :)

First contributors:

  1. @randymcmillan
  2. @jcarucci27

git log bot

npub1fjtdwclt9lspjy8huu3qklr7eklp5uq90u6yh8mec290pqxraccqlufnas

Description
iOS nostr client
Readme GPL-3.0 35 MiB
Languages
Swift 54.1%
C 42%
Assembly 2%
Python 0.6%
Rust 0.5%
Other 0.7%