3 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
3 people	2c3fba5f90	Add test cases for invoices with longer HRP prefixes ... Tests for gh-3456 MAX_PREFIX fix: - lnbc100u (10,000 sats) - 7 char HRP baseline - lnbc130130n (13,013 sats) - 11 char HRP, requires MAX_PREFIX > 10 Root cause: Invoices with "odd" sat amounts use nano-BTC encoding which produces longer HRPs that exceeded old MAX_PREFIX limit. Related: #3456 Signed-off-by: alltheseas <alltheseas@users.noreply.github.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-02 16:10:09 -08:00
3 people	1505a8f2e4	Simplify Swift invoice handling with non-optional return types ... - Mentions.swift: convert_invoice_description now returns non-optional InvoiceDescription, returning empty description for BOLT11 compliance (both description and description_hash are optional per spec) - Block.swift, NdbBlock.swift, NostrEvent.swift, NoteContent.swift: Updated call sites to use non-optional invoice conversion - InvoiceTests.swift: Added test for specific failing invoice Signed-off-by: alltheseas <alltheseas@noreply.github.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-02 16:10:09 -08:00
3 people	845089bed1	Fix Lightning invoice parsing and fetching ... Three issues were causing invoices to not render or fetch: 1. bech32.c: Hardcoded MAX_PREFIX limited HRP length, but BOLT11 HRPs can be arbitrarily long depending on amount. Now derives max HRP length dynamically from input length (len-6 to match bolt11.c buffer). 2. content_parser.c: bolt11_decode_minimal was passed a pointer into the content buffer without null-termination. When a note contained multiple invoices, the decoder would read past the first invoice into newlines and the second invoice, causing checksum failure. Fixed by creating a null-terminated copy using strndup. 3. bolt11.c: bech32_decode_alloc allocated buffers using strlen(str)-6 and strlen(str)-8 without checking minimum length first. For inputs shorter than 8 chars, this caused size_t underflow leading to huge allocations and potential crash. Added early length guard. IMPORTANT: bech32_decode callers must allocate hrp buffer of at least strlen(input) - 6 bytes. This matches existing bolt11.c usage. Changelog-Fixed: Fixed Lightning invoice parsing and fetching for all amounts Closes: https://github.com/damus-io/damus/issues/3456 Closes: https://github.com/damus-io/damus/issues/3151 Signed-off-by: alltheseas <alltheseas@noreply.github.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-02 16:10:09 -08:00