Fix localization build failures

Changelog-Fixed: Fixed localization build failures
Signed-off-by: Terry Yiu <963907+tyiu@users.noreply.github.com>

damus/Models/TranslationService.swift

@@ -59,10 +59,14 @@ enum TranslationService: String, CaseIterable, Identifiable, StringCodable {
     }
 
     static var isAppleTranslationPopoverSupported: Bool {
+#if targetEnvironment(macCatalyst)
+        return false
+#else
         if #available(iOS 17.4, macOS 14.4, *) {
             return true
         } else {
             return false
         }
+#endif
     }
 }

damus/Views/Images/ImageContextMenuModifier.swift

@@ -78,7 +78,7 @@ struct ImageContextMenuModifier: ViewModifier {
                 Label(NSLocalizedString("Share", comment: "Button to share an image."), image: "upload")
             }
         }
-        .alert(NSLocalizedString("Found\n \(qrCodeValue)", comment: "Alert message asking if the user wants to open the link.").truncate(maxLength: 50), isPresented: $open_link_confirm) {
+        .alert(String(format: NSLocalizedString("Found\n %@", comment: "Alert message asking if the user wants to open the link."), qrCodeValue).truncate(maxLength: 50), isPresented: $open_link_confirm) {
             if open_wallet_confirm {
                 Button(NSLocalizedString("Open in wallet", comment: "Button to open the value found in browser."), role: .none) {
                     do {

damus/Views/NoteContentView.swift

@@ -303,7 +303,9 @@ struct NoteContentView: View {
             case .separated(let separated):
                 if #available(iOS 17.4, macOS 14.4, *) {
                     MainContent(artifacts: separated)
+#if !targetEnvironment(macCatalyst)
                         .translationPresentation(isPresented: $isAppleTranslationPopoverPresented, text: event.get_content(damus_state.keypair))
+#endif
                 } else {
                     MainContent(artifacts: separated)
                 }

damus/en-US.xcloc/Source Contents/DamusNotificationService/Localizable.xcstrings

@@ -1,125 +0,0 @@
-{
-  "sourceLanguage" : "en-US",
-  "strings" : {
-    "" : {
-
-    },
-    "(Contents are encrypted)" : {
-      "comment" : "Label on push notification indicating that the contents of the message are encrypted"
-    },
-    "%@ reacted with %@" : {
-      "comment" : "Reacted by heading in local notification",
-      "localizations" : {
-        "en-US" : {
-          "stringUnit" : {
-            "state" : "new",
-            "value" : "%1$@ reacted with %2$@"
-          }
-        }
-      }
-    },
-    "Anonymous" : {
-      "comment" : "Placeholder display name of anonymous user."
-    },
-    "Any" : {
-      "comment" : "Any amount of sats"
-    },
-    "Custom" : {
-      "comment" : "Dropdown option for selecting a custom translation server."
-    },
-    "Damus Purple" : {
-      "comment" : "Dropdown option for selecting Damus Purple as a translation service."
-    },
-    "DeepL (Proprietary, Higher Accuracy)" : {
-      "comment" : "Dropdown option for selecting DeepL as the translation service."
-    },
-    "Free" : {
-      "comment" : "Dropdown option for selecting Free plan for DeepL translation service."
-    },
-    "LibreTranslate (Open Source)" : {
-      "comment" : "Dropdown option for selecting LibreTranslate as the translation service."
-    },
-    "Local" : {
-      "comment" : "Option for notification mode setting: Local notification mode"
-    },
-    "Local default" : {
-      "comment" : "Dropdown option label for system default for Lightning wallet."
-    },
-    "Mentioned by %@" : {
-      "comment" : "Mentioned by heading in local notification"
-    },
-    "Muted event" : {
-      "comment" : "Title for a push notification which has been muted"
-    },
-    "New encrypted direct message" : {
-      "comment" : "Notification that the user has received a new direct message"
-    },
-    "New message" : {
-      "comment" : "Title label for push notifications where a direct message was sent to the user"
-    },
-    "New note reaction" : {
-      "comment" : "Title label for push notifications where someone reacted to the user's post with a specific emoji"
-    },
-    "NoKYCTranslate.com (Prepay with BTC)" : {
-      "comment" : "Dropdown option for selecting NoKYCTranslate.com as the translation service."
-    },
-    "none_translation_service" : {
-      "comment" : "Dropdown option for selecting no translation service.",
-      "extractionState" : "extracted_with_value",
-      "localizations" : {
-        "en-US" : {
-          "stringUnit" : {
-            "state" : "new",
-            "value" : "None"
-          }
-        }
-      }
-    },
-    "Private Zap" : {
-      "comment" : "Title of notification when a private zap is received."
-    },
-    "Pro" : {
-      "comment" : "Dropdown option for selecting Pro plan for DeepL translation service."
-    },
-    "Production" : {
-      "comment" : "Label indicating the production environment for Damus Purple"
-    },
-    "Push" : {
-      "comment" : "Option for notification mode setting: Push notification mode"
-    },
-    "Reposted by %@" : {
-      "comment" : "Reposted by heading in local notification"
-    },
-    "Someone posted a note" : {
-      "comment" : "Title label for push notification where someone posted a note"
-    },
-    "Someone reacted to your note" : {
-      "comment" : "Generic title label for push notifications where someone reacted to the user's post"
-    },
-    "Someone reacted to your note with %@" : {
-      "comment" : "Body label for push notifications where someone reacted to the user's post with a specific emoji"
-    },
-    "Someone zapped you ⚡️" : {
-      "comment" : "Title label for a push notification where someone zapped the user"
-    },
-    "Staging" : {
-      "comment" : "Label indicating a staging test environment for Damus Purple functionality (Developer feature)"
-    },
-    "Test (local)" : {
-      "comment" : "Label indicating a local test environment for Damus Purple functionality (Developer feature)"
-    },
-    "This is an event that has been muted according to your mute list rules. We cannot suppress this notification, but we obscured the details to respect your preferences" : {
-      "comment" : "Description for a push notification which has been muted, and explanation that we cannot suppress it"
-    },
-    "This note contains too many items and cannot be rendered" : {
-      "comment" : "Error message indicating that a note is too big and cannot be rendered"
-    },
-    "translate.nostr.wine (DeepL, Pay with BTC)" : {
-      "comment" : "Dropdown option for selecting translate.nostr.wine as the translation service."
-    },
-    "Zap" : {
-      "comment" : "Title of notification when a non-private zap is received."
-    }
-  },
-  "version" : "1.0"
-}

damus/en-US.xcloc/Source Contents/highlighter action extension/InfoPlist.xcstrings

@@ -0,0 +1,42 @@
+{
+  "sourceLanguage" : "en-US",
+  "strings" : {
+    "CFBundleDisplayName" : {
+      "comment" : "Bundle display name",
+      "extractionState" : "extracted_with_value",
+      "localizations" : {
+        "en-US" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "Highlight on Damus"
+          }
+        }
+      }
+    },
+    "CFBundleName" : {
+      "comment" : "Bundle name",
+      "extractionState" : "extracted_with_value",
+      "localizations" : {
+        "en-US" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : "HighlighterActionExtension"
+          }
+        }
+      }
+    },
+    "NSHumanReadableCopyright" : {
+      "comment" : "Copyright (human-readable)",
+      "extractionState" : "extracted_with_value",
+      "localizations" : {
+        "en-US" : {
+          "stringUnit" : {
+            "state" : "new",
+            "value" : ""
+          }
+        }
+      }
+    }
+  },
+  "version" : "1.0"
+}

damus/en-US.xcloc/contents.json

@@ -3,10 +3,10 @@
   "project" : "damus.xcodeproj",
   "targetLocale" : "en-US",
   "toolInfo" : {
-    "toolBuildNumber" : "15F31d",
+    "toolBuildNumber" : "16A242d",
     "toolID" : "com.apple.dt.xcode",
     "toolName" : "Xcode",
-    "toolVersion" : "15.4"
+    "toolVersion" : "16.0"
   },
   "version" : "1.0"
 }