tyiu/sats-price
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Price conversions break when using a non-US number format #2

New Issue
Open
opened 2025-03-31 14:14:22 +00:00 by tyiu · 1 comment
tyiu commented 2025-03-31 14:14:22 +00:00 (Migrated from github.com)
Copy Link
No description provided.
tyiu commented 2025-04-17 13:10:03 +00:00 (Migrated from github.com)
Copy Link

The issue appears to be that calls to Decimal(string:) do not respect the current locale's number formatting, so a number like 123,45 in a German regional locale has the ,45 decimals dropped. Here is an example, but all call sites that use this method need to be fixed:
482e50b6ba/Sources/SatsPrice/SatsViewModel.swift (L351)

The issue appears to be that calls to `Decimal(string:)` do not respect the current locale's number formatting, so a number like `123,45` in a German regional locale has the `,45` decimals dropped. Here is an example, but all call sites that use this method need to be fixed: https://github.com/tyiu/sats-price/blob/482e50b6bae166e342e88fe039af260d5dfd89c3/Sources/SatsPrice/SatsViewModel.swift#L351
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
tyiu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tyiu/sats-price#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?