Revert "json: deserialize note ids into bytes"

This reverts commit 1ba597fc0a.

enostr/Cargo.lock

@@ -108,7 +108,6 @@ name = "enostr"
 version = "0.1.0"
 dependencies = [
  "ewebsock",
- "hex",
  "serde",
  "serde_derive",
  "serde_json",
@@ -259,12 +258,6 @@ dependencies = [
  "wasi",
 ]
 
-[[package]]
-name = "hex"
-version = "0.4.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7f24254aa9a54b5c858eaee2f5bccdb46aaf0e486a595ed5fd8f86ba55232a70"
-
 [[package]]
 name = "http"
 version = "0.2.8"

enostr/Cargo.toml

@@ -11,4 +11,3 @@ serde_derive = "1"
 serde = { version = "1", features = ["derive"] } # You only need this if you want app persistence
 serde_json = "1.0.89"
 tracing = "0.1.37"
-hex = "0.4.3"

enostr/src/error.rs

@@ -6,7 +6,6 @@ pub enum Error {
     MessageDecodeFailed,
     InvalidSignature,
     Json(serde_json::Error),
-    Hex(hex::FromHexError),
     Generic(String),
 }
 
@@ -37,9 +36,3 @@ impl From<serde_json::Error> for Error {
         Error::Json(e)
     }
 }
-
-impl From<hex::FromHexError> for Error {
-    fn from(e: hex::FromHexError) -> Self {
-        Error::Hex(e)
-    }
-}

enostr/src/event.rs

@@ -1,5 +1,4 @@
 use crate::{Error, Pubkey, Result};
-use hex;
 use serde_derive::{Deserialize, Serialize};
 use std::hash::{Hash, Hasher};
 
@@ -7,7 +6,7 @@ use std::hash::{Hash, Hasher};
 #[derive(Serialize, Deserialize, Debug, Clone)]
 pub struct Event {
     /// 32-bytes sha256 of the the serialized event data
-    pub id: NoteId,
+    pub id: EventId,
     /// 32-bytes hex-encoded public key of the event creator
     #[serde(rename = "pubkey")]
     pub pubkey: Pubkey,
@@ -60,7 +59,7 @@ impl Event {
         sig: &str,
     ) -> Result<Self> {
         let event = Event {
-            id: id.try_into()?,
+            id: id.to_string().into(),
             pubkey: pubkey.to_string().into(),
             created_at,
             kind,
@@ -81,57 +80,17 @@ impl std::str::FromStr for Event {
     }
 }
 
-#[derive(Serialize, Debug, Eq, PartialEq, Clone, Hash)]
-pub struct NoteId([u8; 32]);
+#[derive(Serialize, Deserialize, Debug, Eq, PartialEq, Clone, Hash)]
+pub struct EventId(String);
 
-// Implement `Deserialize` for `NoteId`.
-impl<'de> serde::Deserialize<'de> for NoteId {
-    fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error>
-    where
-        D: serde::Deserializer<'de>,
-    {
-        // Deserialize the JSON string
-        let s = String::deserialize(deserializer)?;
-
-        // Convert the hex string to bytes
-        let bytes = hex::decode(&s).map_err(serde::de::Error::custom)?;
-
-        // Check that the length is exactly 32
-        if bytes.len() != 32 {
-            return Err(serde::de::Error::custom("Expected exactly 32 bytes"));
-        }
-
-        // Convert the Vec<u8> to [u8; 32]
-        let mut array = [0; 32];
-        array.copy_from_slice(&bytes);
-
-        Ok(NoteId(array))
+impl From<String> for EventId {
+    fn from(s: String) -> Self {
+        EventId(s)
     }
 }
 
-impl TryFrom<String> for NoteId {
-    type Error = hex::FromHexError;
-
-    fn try_from(s: String) -> std::result::Result<Self, Self::Error> {
-        let s: &str = &s;
-        NoteId::try_from(s)
-    }
-}
-
-impl From<[u8; 32]> for NoteId {
-    fn from(s: [u8; 32]) -> Self {
-        NoteId(s)
-    }
-}
-
-impl TryFrom<&str> for NoteId {
-    type Error = hex::FromHexError;
-
-    fn try_from(s: &str) -> std::result::Result<Self, Self::Error> {
-        let decoded = hex::decode(s)?;
-        match decoded.try_into() {
-            Ok(bs) => Ok(NoteId(bs)),
-            Err(_) => Err(hex::FromHexError::InvalidStringLength),
-        }
+impl From<EventId> for String {
+    fn from(evid: EventId) -> Self {
+        evid.0
     }
 }

enostr/src/filter.rs

@@ -1,17 +1,17 @@
-use crate::{NoteId, Pubkey};
+use crate::{EventId, Pubkey};
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, Debug, Eq, PartialEq, Clone)]
 pub struct Filter {
     #[serde(skip_serializing_if = "Option::is_none")]
-    ids: Option<Vec<NoteId>>,
+    ids: Option<Vec<EventId>>,
     #[serde(skip_serializing_if = "Option::is_none")]
     authors: Option<Vec<Pubkey>>,
     #[serde(skip_serializing_if = "Option::is_none")]
     kinds: Option<Vec<u64>>,
     #[serde(rename = "#e")]
     #[serde(skip_serializing_if = "Option::is_none")]
-    events: Option<Vec<NoteId>>,
+    events: Option<Vec<EventId>>,
     #[serde(rename = "#p")]
     #[serde(skip_serializing_if = "Option::is_none")]
     pubkeys: Option<Vec<Pubkey>>,
@@ -37,7 +37,7 @@ impl Filter {
         }
     }
 
-    pub fn ids(mut self, ids: Vec<NoteId>) -> Self {
+    pub fn ids(mut self, ids: Vec<EventId>) -> Self {
         self.ids = Some(ids);
         self
     }
@@ -52,7 +52,7 @@ impl Filter {
         self
     }
 
-    pub fn events(mut self, events: Vec<NoteId>) -> Self {
+    pub fn events(mut self, events: Vec<EventId>) -> Self {
         self.events = Some(events);
         self
     }

enostr/src/lib.rs

@@ -8,7 +8,7 @@ mod relay;
 
 pub use client::ClientMessage;
 pub use error::Error;
-pub use event::{Event, NoteId};
+pub use event::{Event, EventId};
 pub use ewebsock;
 pub use filter::Filter;
 pub use profile::Profile;