From 0294d2d1c803be4df7fb60e4100fa2febeed67b6 Mon Sep 17 00:00:00 2001 From: William Casarin Date: Sat, 29 Mar 2025 10:25:08 -0700 Subject: [PATCH] dave: remove default property value and add to description openai doesn't seem to support this Signed-off-by: William Casarin --- crates/notedeck_dave/src/lib.rs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/crates/notedeck_dave/src/lib.rs b/crates/notedeck_dave/src/lib.rs index 48b8c379..4d4379e4 100644 --- a/crates/notedeck_dave/src/lib.rs +++ b/crates/notedeck_dave/src/lib.rs @@ -307,6 +307,7 @@ pub struct Dave { model_config: ModelConfig, } +#[derive(Debug)] pub struct ModelConfig { endpoint: Option, model: String, @@ -732,13 +733,14 @@ impl Tool { "type".to_string(), Value::String(arg.typ.type_string().to_string()), ); - if let Some(default) = &arg.default { - props.insert("default".to_string(), default.clone()); - } - props.insert( - "description".to_string(), - Value::String(arg.description.to_owned()), - ); + + let description = if let Some(default) = &arg.default { + format!("{} (Default: {default}))", arg.description) + } else { + arg.description.to_owned() + }; + + props.insert("description".to_string(), Value::String(description)); if let ArgType::Enum(enums) = &arg.typ { props.insert( "enum".to_string(),