58017952bc
This commit makes several improvements to video coordination, and implements a new video control view. The video support stack in Damus has been re-architected to achieve this. The new architecture can be summarized as follows: 1. `DamusVideoCoordinator` is a singleton object in `DamusState`, and it is responsible for deciding which video should have the "main stage" focus, based on main stage requests that video player views make when they become visible. Having "main stage" focus means that the coordinator will auto-play that video and pause others, and is used throughout the app to determine which video to talk to or control, in the case of app-wide controls (analogous to how Apple Music needs to know which song is playing for displaying playback controls on the iOS home screen) Having a singleton take care of this establishes clear ownership and prevents conflicts such as double-playing video. This coordinator also holds a pool of video media items (`DamusVideoPlayer`), with exactly ONE `DamusVideoPlayer` per URL, to reduce bandwidth and ensure perfect syncing of the same video in different contexts. 2. `DamusVideoPlayer` objects hold the actual media item (video data, playback state), much like `AVPlayer`. In fact, `DamusVideoPlayer` can be described as a wrapper for `AVPlayer`, except it has an interface that is much more SwiftUI friendly, enabling playback state syncing with minimal effort. `DamusVideoPlayer` is NOT a view. And there is only ONE `DamusVideoPlayer` per URL — held by the coordinator. However, when the app needs to display that same video in multiple places, the app can instantiate multiple video player VIEWS of the same `DamusVideoPlayer` 3. `DamusVideoPlayer.BaseView` is the most basic video player view for a `DamusVideoPlayer` item. It has basically no features other than showing the video itself. 4. `DamusVideoPlayerView` is the standard, batteries-included, video player view for `DamusVideoPlayer` items, that is used throughout the app. It also tries to detect its own visibility, and makes requests to `DamusVideoCoordinator` to take over the main stage when it becomes visible. 5. `DamusVideoControlsView` is a view that presents video playback controls (play/pause, mute, scrubbing) for a `DamusVideoPlayer` object. How a `DamusVideoPlayerView` gains and loses main stage focus: 1. `DamusVideoPlayerView` uses `VisibilityTracker` to find out when it becomes visible or not 2. When it becomes visible, it makes a request to the video coordinator to take main stage focus. The request also specifies which layer the video view is in (Full screen layer? Normal app layer?), which the video player view gets from the `\.view_layer_context` environment variable set by `damus_full_screen_cover` 3. The coordinator (`DamusVideoCoordinator`) keeps all of these requests, and uses its own internal logic and info to determine which video should get the main stage. The logic also depends on whether or not the app finds itself in full screen mode. Once the main stage is given to a different video, the previous video is paused, the main-staged-video is played, and the requestor receives a callback. 4. Once the video disappears from view, it tells the coordinator that it is giving up the main stage, and the coordinator then picks another main stage request again. On top of this, several of other small changes and improvements were made, such as video gesture improvements Note: This commit causes some breakage over the image carousel sizing logic, which will be addressed separately in the next commit. Changelog-Fixed: Fixed iOS 18 gesture issues that would take user to the thread view when clicking on a video or unmuting it Changelog-Fixed: Fixed several issues that would cause video to automatically play or pause incorrectly Changelog-Fixed: Fixed issue where full screen video would disappear when going to landscape mode Changelog-Added: Added new easy to use video controls for full screen video Changelog-Changed: Improved video syncing and bandwidth usage when switching between timeline video and full screen mode Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
249 lines
9.4 KiB
Swift
249 lines
9.4 KiB
Swift
//
|
|
// DamusVideoPlayer.swift
|
|
// damus
|
|
//
|
|
// Created by Bryan Montz on 9/5/23.
|
|
//
|
|
|
|
import AVFoundation
|
|
import AVKit
|
|
import Combine
|
|
import Foundation
|
|
import SwiftUI
|
|
|
|
/// DamusVideoPlayer has the function of wrapping `AVPlayer` and exposing a control interface that integrates seamlessly with SwiftUI views
|
|
///
|
|
/// This is **NOT** a video player view. This is a headless video object concerned about the video and its playback. To display a video, you need `DamusVideoPlayerView`
|
|
/// This is also **NOT** a control view. Please see `DamusVideoControlsView` for that.
|
|
///
|
|
/// **Implementation notes:**
|
|
/// - `@MainActor` is needed because `@Published` properties need to be updated on the main thread to avoid SwiftUI mutations within a single render pass
|
|
/// - `@Published` variables are the chosen interface because they integrate very seamlessly with SwiftUI views. Avoid the use of procedural functions to avoid SwiftUI state desync.
|
|
@MainActor final class DamusVideoPlayer: ObservableObject {
|
|
|
|
// MARK: Immutable foundational instance members
|
|
|
|
/// The URL of the video
|
|
let url: URL
|
|
/// The underlying AVPlayer that we are wrapping.
|
|
/// This is not public because we don't want any callers of this class controlling the `AVPlayer` directly, we want them to go through our interface
|
|
/// This measure helps avoid state inconsistencies and other flakiness. DO NOT USE THIS OUTSIDE `DamusVideoPlayer`
|
|
private let player: AVPlayer
|
|
|
|
|
|
// MARK: SwiftUI-friendly interface
|
|
|
|
/// Indicates whether the video has audio at all
|
|
@Published private(set) var has_audio = false
|
|
/// Whether whether this is a live video
|
|
@Published private(set) var is_live = false
|
|
/// The video size
|
|
@Published private(set) var video_size: CGSize?
|
|
/// Whether or not to mute the video
|
|
@Published var is_muted = true {
|
|
didSet {
|
|
if oldValue == is_muted { return }
|
|
player.isMuted = is_muted
|
|
}
|
|
}
|
|
/// Whether the video is loading
|
|
@Published private(set) var is_loading = true
|
|
/// The current time of playback, in seconds
|
|
/// Usage note: If editing (such as in a slider), make sure to set `is_editing_current_time` to `true` to detach this value from the current playback
|
|
@Published var current_time: TimeInterval = .zero
|
|
/// Whether video is playing or not
|
|
@Published var is_playing = false {
|
|
didSet {
|
|
if oldValue == is_playing { return }
|
|
// When scrubbing, the playback control is temporarily decoupled, so don't play/pause our `AVPlayer`
|
|
// When scrubbing stops, the `is_editing_current_time` handler will automatically play/pause depending on `is_playing`
|
|
if is_editing_current_time { return }
|
|
if is_playing {
|
|
player.play()
|
|
}
|
|
else {
|
|
player.pause()
|
|
}
|
|
}
|
|
}
|
|
/// Whether the current time is being manually edited (e.g. when user is scrubbing through the video)
|
|
/// **Implementation note:** When set to `true`, this decouples the `current_time` from the video playback observer — in a way analogous to a clutch on a standard transmission car, if you are into Automotive engineering.
|
|
@Published var is_editing_current_time = false {
|
|
didSet {
|
|
if oldValue == is_editing_current_time { return }
|
|
if !is_editing_current_time {
|
|
Task {
|
|
await self.player.seek(to: CMTime(seconds: current_time, preferredTimescale: 60))
|
|
// Start playing video again, if we were playing before scrubbing
|
|
if self.is_playing {
|
|
self.player.play()
|
|
}
|
|
}
|
|
}
|
|
else {
|
|
// Pause playing video, if we were playing before we started scrubbing
|
|
if self.is_playing { self.player.pause() }
|
|
}
|
|
}
|
|
}
|
|
/// The duration of the video, in seconds.
|
|
var duration: TimeInterval? {
|
|
return player.currentItem?.duration.seconds
|
|
}
|
|
|
|
// MARK: Internal instance members
|
|
|
|
private var cancellables = Set<AnyCancellable>()
|
|
private var videoSizeObserver: NSKeyValueObservation?
|
|
private var videoDurationObserver: NSKeyValueObservation?
|
|
private var videoCurrentTimeObserver: Any?
|
|
private var videoIsPlayingObserver: NSKeyValueObservation?
|
|
|
|
|
|
// MARK: - Initialization
|
|
|
|
public init(url: URL) {
|
|
self.url = url
|
|
self.player = AVPlayer(playerItem: AVPlayerItem(url: url))
|
|
self.video_size = nil
|
|
|
|
Task {
|
|
await load()
|
|
}
|
|
|
|
player.isMuted = is_muted
|
|
|
|
NotificationCenter.default.addObserver(
|
|
self,
|
|
selector: #selector(did_play_to_end),
|
|
name: Notification.Name.AVPlayerItemDidPlayToEndTime,
|
|
object: player.currentItem
|
|
)
|
|
|
|
observeVideoSize()
|
|
observeDuration()
|
|
observeCurrentTime()
|
|
observeVideoIsPlaying()
|
|
}
|
|
|
|
// MARK: - Observers
|
|
// Functions that allow us to observe certain variables and publish their changes for view updates
|
|
// These are all private because they are part of the internal logic
|
|
|
|
private func observeVideoSize() {
|
|
videoSizeObserver = player.currentItem?.observe(\.presentationSize, options: [.new], changeHandler: { [weak self] (playerItem, change) in
|
|
guard let self else { return }
|
|
if let newSize = change.newValue, newSize != .zero {
|
|
DispatchQueue.main.async {
|
|
self.video_size = newSize // Update the bound value
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
private func observeDuration() {
|
|
videoDurationObserver = player.currentItem?.observe(\.duration, options: [.new], changeHandler: { [weak self] (playerItem, change) in
|
|
guard let self else { return }
|
|
if let newDuration = change.newValue, newDuration != .zero {
|
|
DispatchQueue.main.async {
|
|
self.is_live = newDuration == .indefinite
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
private func observeCurrentTime() {
|
|
videoCurrentTimeObserver = player.addPeriodicTimeObserver(forInterval: CMTime(seconds: 1, preferredTimescale: 600), queue: .main) { [weak self] time in
|
|
guard let self else { return }
|
|
DispatchQueue.main.async { // Must use main thread to update @Published properties
|
|
if self.is_editing_current_time == false {
|
|
self.current_time = time.seconds
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
private func observeVideoIsPlaying() {
|
|
videoIsPlayingObserver = player.observe(\.rate, changeHandler: { [weak self] (player, change) in
|
|
guard let self else { return }
|
|
guard let new_rate = change.newValue else { return }
|
|
DispatchQueue.main.async {
|
|
self.is_playing = new_rate > 0
|
|
}
|
|
})
|
|
}
|
|
|
|
// MARK: - Other internal logic functions
|
|
|
|
private func load() async {
|
|
has_audio = await self.video_has_audio()
|
|
is_loading = false
|
|
}
|
|
|
|
private func video_has_audio() async -> Bool {
|
|
do {
|
|
let hasAudibleTracks = ((try await player.currentItem?.asset.loadMediaSelectionGroup(for: .audible)) != nil)
|
|
let tracks = try? await player.currentItem?.asset.load(.tracks)
|
|
let hasAudioTrack = tracks?.filter({ t in t.mediaType == .audio }).first != nil // Deal with odd cases of audio only MOV
|
|
return hasAudibleTracks || hasAudioTrack
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|
|
|
|
@objc private func did_play_to_end() {
|
|
player.seek(to: CMTime.zero)
|
|
player.play()
|
|
}
|
|
|
|
// MARK: - Deinit
|
|
|
|
deinit {
|
|
videoSizeObserver?.invalidate()
|
|
videoDurationObserver?.invalidate()
|
|
videoIsPlayingObserver?.invalidate()
|
|
}
|
|
|
|
// MARK: - Convenience interface functions
|
|
|
|
func play() {
|
|
self.is_playing = true
|
|
}
|
|
|
|
func pause() {
|
|
self.is_playing = false
|
|
}
|
|
}
|
|
|
|
extension DamusVideoPlayer {
|
|
/// The simplest view for a `DamusVideoPlayer` object.
|
|
///
|
|
/// Other views with more features should use this as a base.
|
|
///
|
|
/// ## Implementation notes:
|
|
///
|
|
/// 1. This is defined inside `DamusVideoPlayer` to allow it to access the private `AVPlayer` instance required to initialize it, which is otherwise hidden away from every other class.
|
|
/// 2. DO NOT write any `AVPlayer` control/manipulation code, the `AVPlayer` instance is owned by `DamusVideoPlayer` and only managed there to keep things sane.
|
|
struct BaseView: UIViewControllerRepresentable {
|
|
|
|
let player: DamusVideoPlayer
|
|
let show_playback_controls: Bool
|
|
|
|
func makeUIViewController(context: Context) -> AVPlayerViewController {
|
|
let controller = AVPlayerViewController()
|
|
controller.showsPlaybackControls = show_playback_controls
|
|
return controller
|
|
}
|
|
|
|
func updateUIViewController(_ uiViewController: AVPlayerViewController, context: Context) {
|
|
if uiViewController.player == nil {
|
|
uiViewController.player = player.player
|
|
}
|
|
}
|
|
|
|
static func dismantleUIViewController(_ uiViewController: AVPlayerViewController, coordinator: ()) {
|
|
uiViewController.player = nil
|
|
}
|
|
}
|
|
}
|