This commit fixes a crash that occurred when clicking "follow all" during onboarding. This fix works by making `Contacts` and `PostBox` isolated into a specific Swift Actor, and updating direct and indirect usages accordingly. Changelog-Fixed: Fixed a crash that occurred when clicking "follow all" during onboarding. Closes: https://github.com/damus-io/damus/issues/3422 Co-authored-by: alltheseas <64376233+alltheseas@users.noreply.github.com> Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
225 lines
7.5 KiB
Swift
225 lines
7.5 KiB
Swift
//
|
|
// ProfileModel.swift
|
|
// damus
|
|
//
|
|
// Created by William Casarin on 2022-04-27.
|
|
//
|
|
|
|
import Foundation
|
|
|
|
class ProfileModel: ObservableObject, Equatable {
|
|
@Published var contacts: NostrEvent? = nil
|
|
@Published var following: Int = 0
|
|
@Published var relay_list: NIP65.RelayList? = nil
|
|
@Published var legacy_relay_list: [RelayURL: LegacyKind3RelayRWConfiguration]? = nil
|
|
@Published var progress: Int = 0
|
|
var relay_urls: [RelayURL]? {
|
|
if let relay_list {
|
|
return relay_list.relays.values.map({ $0.url })
|
|
}
|
|
if let legacy_relay_list {
|
|
return Array(legacy_relay_list.keys)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
private let MAX_SHARE_RELAYS = 4
|
|
|
|
var events: EventHolder
|
|
let pubkey: Pubkey
|
|
let damus: DamusState
|
|
|
|
@MainActor // Isolate this to the main actor to avoid crashes arising from race conditions
|
|
var seen_event: Set<NoteId> = Set()
|
|
|
|
var findRelaysListener: Task<Void, Never>? = nil
|
|
var listener: Task<Void, Never>? = nil
|
|
var profileListener: Task<Void, Never>? = nil
|
|
var conversationListener: Task<Void, Never>? = nil
|
|
|
|
var conversation_events: Set<NoteId> = Set()
|
|
|
|
init(pubkey: Pubkey, damus: DamusState) {
|
|
self.pubkey = pubkey
|
|
self.damus = damus
|
|
self.events = EventHolder(on_queue: { ev in
|
|
preload_events(state: damus, events: [ev])
|
|
})
|
|
}
|
|
|
|
func follows(pubkey: Pubkey) -> Bool {
|
|
guard let contacts = self.contacts else {
|
|
return false
|
|
}
|
|
|
|
return contacts.referenced_pubkeys.contains(pubkey)
|
|
}
|
|
|
|
func get_follow_target() -> FollowTarget {
|
|
if let contacts = contacts {
|
|
return .contact(contacts)
|
|
}
|
|
return .pubkey(pubkey)
|
|
}
|
|
|
|
static func == (lhs: ProfileModel, rhs: ProfileModel) -> Bool {
|
|
return lhs.pubkey == rhs.pubkey
|
|
}
|
|
|
|
func hash(into hasher: inout Hasher) {
|
|
hasher.combine(pubkey)
|
|
}
|
|
|
|
func subscribe() {
|
|
print("subscribing to profile \(pubkey)")
|
|
listener?.cancel()
|
|
listener = Task {
|
|
var text_filter = NostrFilter(kinds: [.text, .longform, .highlight])
|
|
text_filter.authors = [pubkey]
|
|
text_filter.limit = 500
|
|
await bumpUpProgress()
|
|
for await event in damus.nostrNetwork.reader.streamIndefinitely(filters: [text_filter]) {
|
|
event.justUseACopy({ handleNostrEvent($0) })
|
|
}
|
|
}
|
|
profileListener?.cancel()
|
|
profileListener = Task {
|
|
var profile_filter = NostrFilter(kinds: [.contacts, .metadata, .boost])
|
|
var relay_list_filter = NostrFilter(kinds: [.relay_list], authors: [pubkey])
|
|
profile_filter.authors = [pubkey]
|
|
await bumpUpProgress()
|
|
for await event in damus.nostrNetwork.reader.streamIndefinitely(filters: [profile_filter, relay_list_filter]) {
|
|
event.justUseACopy({ handleNostrEvent($0) })
|
|
}
|
|
|
|
}
|
|
conversationListener?.cancel()
|
|
conversationListener = Task {
|
|
await listenToConversations()
|
|
}
|
|
}
|
|
|
|
@MainActor
|
|
func bumpUpProgress() {
|
|
progress += 1
|
|
}
|
|
|
|
func listenToConversations() async {
|
|
// Only subscribe to conversation events if the profile is not us.
|
|
guard pubkey != damus.pubkey else {
|
|
return
|
|
}
|
|
|
|
let conversation_kinds: [NostrKind] = [.text, .longform, .highlight]
|
|
let limit: UInt32 = 500
|
|
let conversations_filter_them = NostrFilter(kinds: conversation_kinds, pubkeys: [damus.pubkey], limit: limit, authors: [pubkey])
|
|
let conversations_filter_us = NostrFilter(kinds: conversation_kinds, pubkeys: [pubkey], limit: limit, authors: [damus.pubkey])
|
|
print("subscribing to conversation events from and to profile \(pubkey)")
|
|
for await noteLender in self.damus.nostrNetwork.reader.streamIndefinitely(filters: [conversations_filter_them, conversations_filter_us]) {
|
|
guard let event = noteLender.justGetACopy() else { continue }
|
|
if await !seen_event.contains(event.id) {
|
|
Task { await self.add_event(event) }
|
|
conversation_events.insert(event.id)
|
|
}
|
|
else if !conversation_events.contains(event.id) {
|
|
conversation_events.insert(event.id)
|
|
}
|
|
}
|
|
}
|
|
|
|
func unsubscribe() {
|
|
listener?.cancel()
|
|
listener = nil
|
|
profileListener?.cancel()
|
|
profileListener = nil
|
|
conversationListener?.cancel()
|
|
conversationListener = nil
|
|
}
|
|
|
|
@MainActor
|
|
func handle_profile_contact_event(_ ev: NostrEvent) {
|
|
process_contact_event(state: damus, ev: ev)
|
|
|
|
// only use new stuff
|
|
if let current_ev = self.contacts {
|
|
guard ev.created_at > current_ev.created_at else {
|
|
return
|
|
}
|
|
}
|
|
|
|
self.contacts = ev
|
|
self.following = count_pubkeys(ev.tags)
|
|
self.legacy_relay_list = decode_json_relays(ev.content)
|
|
}
|
|
|
|
@MainActor
|
|
func add_event(_ ev: NostrEvent) {
|
|
guard ev.should_show_event else {
|
|
return
|
|
}
|
|
|
|
if ev.is_textlike || ev.known_kind == .boost {
|
|
if self.events.insert(ev) {
|
|
self.objectWillChange.send()
|
|
}
|
|
} else if ev.known_kind == .contacts {
|
|
handle_profile_contact_event(ev)
|
|
}
|
|
else if ev.known_kind == .relay_list {
|
|
self.relay_list = try? NIP65.RelayList(event: ev) // Whether another user's list is malformatted is something beyond our control. Probably best to suppress errors
|
|
}
|
|
seen_event.insert(ev.id)
|
|
}
|
|
|
|
private func handleNostrEvent(_ ev: NostrEvent) {
|
|
// Ensure the event public key matches this profiles public key
|
|
// This is done to protect against a relay not properly filtering events by the pubkey
|
|
// See https://github.com/damus-io/damus/issues/1846 for more information
|
|
guard self.pubkey == ev.pubkey else { return }
|
|
Task { await add_event(ev) }
|
|
}
|
|
|
|
private func findRelaysHandler(relay_id: RelayURL, ev: NostrConnectionEvent) {
|
|
if case .nostr_event(let resp) = ev, case .event(_, let event) = resp, case .contacts = event.known_kind {
|
|
self.legacy_relay_list = decode_json_relays(event.content)
|
|
}
|
|
}
|
|
|
|
func subscribeToFindRelays() {
|
|
var profile_filter = NostrFilter(kinds: [.contacts])
|
|
profile_filter.authors = [pubkey]
|
|
self.findRelaysListener?.cancel()
|
|
self.findRelaysListener = Task {
|
|
for await noteLender in damus.nostrNetwork.reader.streamIndefinitely(filters: [profile_filter]) {
|
|
try? noteLender.borrow { event in
|
|
if case .contacts = event.known_kind {
|
|
// TODO: Is this correct?
|
|
self.legacy_relay_list = decode_json_relays(event.content)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func unsubscribeFindRelays() {
|
|
self.findRelaysListener?.cancel()
|
|
self.findRelaysListener = nil
|
|
}
|
|
|
|
func getCappedRelays() -> [RelayURL] {
|
|
return relay_list?.relays.keys.prefix(Constants.MAX_SHARE_RELAYS).map { $0 } ?? []
|
|
}
|
|
}
|
|
|
|
|
|
func count_pubkeys(_ tags: Tags) -> Int {
|
|
var c: Int = 0
|
|
for tag in tags {
|
|
if tag.count >= 2 && tag[0].matches_char("p") {
|
|
c += 1
|
|
}
|
|
}
|
|
|
|
return c
|
|
}
|