Daniel D’Aquino
20dc672dbf
This adds a sync mechanism in Ndb.swift to coordinate certain usage of nostrdb.c calls and the need to close nostrdb due to app lifecycle requirements. Furthermore, it fixes the order of operations when re-opening NostrDB, to avoid race conditions where a query uses an older Ndb generation. This sync mechanism allows multiple queries to happen simultaneously (from the Swift-side), while preventing ndb from simultaneously closing during such usages. It also does that while keeping the Ndb interface sync and nonisolated, which keeps the API easy to use from Swift/SwiftUI and allows for parallel operations to occur. If Swift Actors were to be used (e.g. creating an NdbActor), the Ndb.swift interface would change in such a way that it would propagate the need for several changes throughout the codebase, including loading logic in some ViewModels. Furthermore, it would likely decrease performance by forcing Ndb.swift operations to run sequentially when they could run in parallel. Changelog-Fixed: Fixed crashes that happened when the app went into background mode Closes: https://github.com/damus-io/damus/issues/3245 Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
62 lines
2.1 KiB
Swift
62 lines
2.1 KiB
Swift
//
|
|
// ReplyDescription.swift
|
|
// damus
|
|
//
|
|
// Created by William Casarin on 2023-01-23.
|
|
//
|
|
|
|
import SwiftUI
|
|
|
|
// jb55 - TODO: this could be a lot better
|
|
struct ReplyDescription: View {
|
|
let event: NostrEvent
|
|
let replying_to: NostrEvent?
|
|
let ndb: Ndb
|
|
|
|
var body: some View {
|
|
Text(verbatim: "\(reply_desc(ndb: ndb, event: event, replying_to: replying_to))")
|
|
.font(.footnote)
|
|
.foregroundColor(.gray)
|
|
.frame(maxWidth: .infinity, alignment: .leading)
|
|
}
|
|
}
|
|
|
|
struct ReplyDescription_Previews: PreviewProvider {
|
|
static var previews: some View {
|
|
ReplyDescription(event: test_note, replying_to: test_note, ndb: test_damus_state.ndb)
|
|
}
|
|
}
|
|
|
|
func reply_desc(ndb: Ndb, event: NostrEvent, replying_to: NostrEvent?, locale: Locale = Locale.current) -> String {
|
|
let desc = make_reply_description(event, replying_to: replying_to)
|
|
let pubkeys = desc.pubkeys
|
|
let n = desc.others
|
|
|
|
let bundle = bundleForLocale(locale: locale)
|
|
|
|
if desc.pubkeys.count == 0 {
|
|
return NSLocalizedString("Replying to self", bundle: bundle, comment: "Label to indicate that the user is replying to themself.")
|
|
}
|
|
|
|
let names: [String] = pubkeys.map { pk in
|
|
let profile = try? ndb.lookup_profile_and_copy(pk)
|
|
|
|
return Profile.displayName(profile: profile, pubkey: pk).username.truncate(maxLength: 50)
|
|
}
|
|
|
|
let uniqueNames = NSOrderedSet(array: names).array as! [String]
|
|
|
|
if uniqueNames.count > 1 {
|
|
let othersCount = n - pubkeys.count
|
|
if othersCount <= 0 {
|
|
return String(format: NSLocalizedString("Replying to %@ & %@", bundle: bundle, comment: "Label to indicate that the user is replying to 2 users."), locale: locale, uniqueNames[0], uniqueNames[1])
|
|
} else {
|
|
return String(format: localizedStringFormat(key: "replying_to_two_and_others", locale: locale), locale: locale, othersCount, uniqueNames[0], uniqueNames[1])
|
|
}
|
|
}
|
|
|
|
return String(format: NSLocalizedString("Replying to %@", bundle: bundle, comment: "Label to indicate that the user is replying to 1 user."), locale: locale, uniqueNames[0])
|
|
}
|
|
|
|
|