f844ed9931
This commit redesigns the Ndb.swift interface with a focus on build-time safety against crashes. It removes the external usage of NdbTxn and SafeNdbTxn, restricting it to be used only in NostrDB internal code. This prevents dangerous and crash prone usages throughout the app, such as holding transactions in a variable in an async function (which can cause thread-based reference counting to incorrectly deinit inherited transactions in use by separate callers), as well as holding unsafe unowned values longer than the lifetime of their corresponding transactions. Closes: https://github.com/damus-io/damus/issues/3364 Changelog-Fixed: Fixed several crashes throughout the app Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
40 lines
1.5 KiB
Swift
40 lines
1.5 KiB
Swift
//
|
||
// Ndb+.swift
|
||
// damus
|
||
//
|
||
// Created by Daniel D’Aquino on 2025-04-04.
|
||
//
|
||
|
||
/// ## Implementation notes
|
||
///
|
||
/// 1. This was created as a separate file because it contains dependencies to damus-specific structures such as `NostrFilter`, which is not yet available inside the NostrDB codebase.
|
||
|
||
import Foundation
|
||
|
||
extension Ndb {
|
||
/// Subscribe to events matching the provided NostrFilters
|
||
/// - Parameters:
|
||
/// - filters: Array of NostrFilter objects
|
||
/// - maxSimultaneousResults: Maximum number of initial results to return
|
||
/// - Returns: AsyncStream of StreamItem events
|
||
/// - Throws: NdbStreamError if subscription fails
|
||
func subscribe(filters: [NostrFilter], maxSimultaneousResults: Int = 1000) throws -> AsyncStream<StreamItem> {
|
||
let ndbFilters: [NdbFilter]
|
||
do {
|
||
ndbFilters = try filters.toNdbFilters()
|
||
} catch {
|
||
throw NdbStreamError.cannotConvertFilter(error)
|
||
}
|
||
return try self.subscribe(filters: ndbFilters, maxSimultaneousResults: maxSimultaneousResults)
|
||
}
|
||
|
||
/// Determines if a given note was seen on any of the listed relay URLs
|
||
func was(noteKey: NoteKey, seenOnAnyOf relayUrls: [RelayURL]) throws -> Bool {
|
||
return try self.was(noteKey: noteKey, seenOnAnyOf: relayUrls.map({ $0.absoluteString }))
|
||
}
|
||
|
||
func processEvent(_ str: String, originRelayURL: RelayURL? = nil) -> Bool {
|
||
self.process_event(str, originRelayURL: originRelayURL?.absoluteString)
|
||
}
|
||
}
|