From c3e94f367c6ba047c9b3429a08af46d773f11007 Mon Sep 17 00:00:00 2001 From: William Casarin Date: Wed, 10 Jan 2024 09:49:04 -0800 Subject: [PATCH] docs: update CONTRIBUTING to mention v2 patch series I realized we didn't have this in the contributor docs. Noone will read it, but at least we'll have something to point to for future contributors. Cc: kernelkind Signed-off-by: William Casarin --- docs/CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 069eeb18..5590481d 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -54,6 +54,10 @@ find the patch description and put that into the patch. I.e., the patch the maintainers and reviewers. Some reviewers probably didn't even receive earlier versions of the patch. +When submitting a -v2 of more than one patch, ensure that you include all of +the original patches, don't just send a v2 of one of the patches. If you +are dropping a patch, mention it in the `patch changelog`. + Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change