tyiu/damus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nostrdb: relay: fix potential relay index corruption

Browse Source 
Signed-off-by: William Casarin <jb55@jb55.com>
This commit is contained in:
William Casarin
2025-03-21 15:39:01 -07:00
committed by Daniel D’Aquino
parent a0b85129d4
commit af2298dcb7
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
nostrdb/src/nostrdb.c
View File

@@ -1973,6 +1973,13 @@ struct ndb_writer_note {
const char *relay; const char *relay;
}; };
static void ndb_writer_note_init(struct ndb_writer_note *writer_note, struct ndb_note *note, size_t note_len, const char *relay)
{
writer_note->note = note;
writer_note->note_len = note_len;
writer_note->relay = relay;
}
struct ndb_writer_profile { struct ndb_writer_profile {
struct ndb_writer_note note; struct ndb_writer_note note;
struct ndb_profile_record_builder record; struct ndb_profile_record_builder record;
@@ -2073,8 +2080,7 @@ static int ndb_migrate_utf8_profile_names(struct ndb_txn *txn)
copied_note = malloc(len); copied_note = malloc(len);
memcpy(copied_note, note, len); memcpy(copied_note, note, len);
profile.note.note = copied_note; ndb_writer_note_init(&profile.note, copied_note, len, NULL);
profile.note.note_len = len;
// we don't pass in flags when migrating... a bit sketchy but // we don't pass in flags when migrating... a bit sketchy but
// whatever. noone is using this to customize nostrdb atm // whatever. noone is using this to customize nostrdb atm
@@ -2573,8 +2579,7 @@ static int ndb_ingester_process_note(secp256k1_context *ctx,
ndb_process_profile_note(note, b); ndb_process_profile_note(note, b);
out->type = NDB_WRITER_PROFILE; out->type = NDB_WRITER_PROFILE;
out->profile.note.note = note; ndb_writer_note_init(&out->profile.note, note, note_size, relay);
out->profile.note.note_len = note_size;
return 1; return 1;
} else if (note->kind == 6) { } else if (note->kind == 6) {
// process the repost if we have a repost event // process the repost if we have a repost event
@@ -2587,9 +2592,7 @@ static int ndb_ingester_process_note(secp256k1_context *ctx,
} }
out->type = NDB_WRITER_NOTE; out->type = NDB_WRITER_NOTE;
out->note.note = note; ndb_writer_note_init(&out->note, note, note_size, relay);
out->note.note_len = note_size;
out->note.relay = relay;
return 1; return 1;
} }