network: Broadcast quoted notes when posting a note with quotes
This change addresses an issue where notes with quotes sometimes are not loaded correctly because the quoted note was not available in the same relay. Now whenever a user posts a note with a quoted note, the quoted note is also broadcast to the user's selected relays. Issue repro ----------- ISSUE REPRODUCED Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: `1fabd4c0fe98d1f47b1fa0f76984ad78095bd49c` Setup: - Make sure you have a debugger connected - Have a test note that you can quote Steps: 1. Start Damus and let logs settle 2. Observe where the last log is 3. Quote the test note 4. Copy newly generated logs and paste on a text editor. 5. Analyze those logs. Pay attention to the new note id, as well as the note id of the quoted event (`["q", <QUOTED_NOTE_ID>]`) Results: Logs show that the newly posted event is being flushed to the relays, but not the note that is being quoted. Testing of the fix ------------------ PASS Device: iPhone 14 Pro Simulator iOS: 17.0 Damus: This commit Setup: - Make sure you have a debugger connected - Have a test note that you can quote Steps: 1. Start Damus and let logs settle 2. Observe where the last log is 3. Quote the test note 4. Copy newly generated logs and paste on a text editor. 5. Analyze those logs. Pay attention to the new note id, as well as the note id of the quoted event (`["q", <QUOTED_NOTE_ID>]`) Results: - Logs show the new event being flushed to the relays. PASS - Logs show the quoted event also being flushed to the relays. PASS Closes: https://github.com/damus-io/damus/issues/1495 Changelog-Fixed: Broadcast quoted notes when posting a note with quotes Signed-off-by: Daniel D’Aquino <daniel@daquino.me> Reviewed-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This commit is contained in:
committed by
William Casarin
parent
0f9e87cb37
commit
a06be64894
@@ -292,6 +292,10 @@ extension NdbNote {
|
||||
public var referenced_ids: References<NoteId> {
|
||||
References<NoteId>(tags: self.tags)
|
||||
}
|
||||
|
||||
public var referenced_quote_ids: References<QuoteId> {
|
||||
References<QuoteId>(tags: self.tags)
|
||||
}
|
||||
|
||||
public var referenced_noterefs: References<NoteRef> {
|
||||
References<NoteRef>(tags: self.tags)
|
||||
|
||||
Reference in New Issue
Block a user