tyiu/damus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove language filtering from Universe feed because language detection can be inaccurate

Browse Source 
Changelog-Removed: Removed language filtering from Universe feed because language detection can be inaccurate

Signed-off-by: Terry Yiu <git@tyiu.xyz>
This commit is contained in:
Terry Yiu
2025-01-19 13:21:31 -05:00
parent 7b4fc79030
commit 8e852ed742
3 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
damus/Models/UserSettingsStore.swift
View File

@@ -186,9 +186,6 @@ class UserSettingsStore: ObservableObject {
@Setting(key: "show_music_statuses", default_value: true) @Setting(key: "show_music_statuses", default_value: true)
var show_music_statuses: Bool var show_music_statuses: Bool
@Setting(key: "show_only_preferred_languages", default_value: false)
var show_only_preferred_languages: Bool
@Setting(key: "multiple_events_per_pubkey", default_value: false) @Setting(key: "multiple_events_per_pubkey", default_value: false)
var multiple_events_per_pubkey: Bool var multiple_events_per_pubkey: Bool

13
damus/Views/SearchHomeView.swift
View File

@@ -62,18 +62,7 @@ struct SearchHomeView: View {
return false return false
} }
if damus_state.settings.show_only_preferred_languages == false { return true
return true
}
// If we can't determine the note's language with 50%+ confidence, lean on the side of caution and show it anyway.
let note_lang = damus_state.events.get_cache_data(ev.id).translations_model.note_language
guard let note_lang else {
return true
}
let currentLanguage = localeToLanguage(Locale.current.identifier)
return currentLanguage == note_lang
}, },
content: { content: {
AnyView(VStack { AnyView(VStack {

3
damus/Views/Settings/TranslationSettingsView.swift
View File

@@ -16,9 +16,6 @@ struct TranslationSettingsView: View {
var body: some View { var body: some View {
Form { Form {
Section(NSLocalizedString("Translations", comment: "Section title for selecting the translation service.")) { Section(NSLocalizedString("Translations", comment: "Section title for selecting the translation service.")) {
Toggle(NSLocalizedString("Show only preferred languages on Universe feed", comment: "Toggle to show notes that are only in the device's preferred languages on the Universe feed and hide notes that are in other languages."), isOn: $settings.show_only_preferred_languages)
.toggleStyle(.switch)
Picker(NSLocalizedString("Service", comment: "Prompt selection of translation service provider."), selection: $settings.translation_service) { Picker(NSLocalizedString("Service", comment: "Prompt selection of translation service provider."), selection: $settings.translation_service) {
ForEach(TranslationService.allCases.filter({ damus_state.purple.enable_purple ? true : $0 != .purple }), id: \.self) { server in ForEach(TranslationService.allCases.filter({ damus_state.purple.enable_purple ? true : $0 != .purple }), id: \.self) { server in
Text(server.model.displayName) Text(server.model.displayName)