Fix onboarding crash

This commit fixes a crash that occurred when clicking "follow all"
during onboarding.

This fix works by making `Contacts` and `PostBox` isolated into a
specific Swift Actor, and updating direct and indirect usages
accordingly.

Changelog-Fixed: Fixed a crash that occurred when clicking "follow all" during onboarding.
Closes: https://github.com/damus-io/damus/issues/3422
Co-authored-by: alltheseas <64376233+alltheseas@users.noreply.github.com>
Signed-off-by: Daniel D’Aquino <daniel@daquino.me>

damusTests/DamusCacheManagerTests.swift

@@ -23,6 +23,7 @@ final class DamusCacheManagerTests: XCTestCase {
     }
     
     /// Simple smoke test to check if clearing cache will crash the system
+    @MainActor
     func testCacheManagerSmoke() throws {
         for _ in Range(0...20) {
             DamusCacheManager.shared.clear_cache(damus_state: test_damus_state)

damusTests/EventGroupViewTests.swift

@@ -18,6 +18,7 @@ final class EventGroupViewTests: XCTestCase {
         // Put teardown code here. This method is called after the invocation of each test method in the class.
     }
 
+    @MainActor
     func testEventAuthorName() {
         let damusState = test_damus_state
         let damus_name = "17ldvg64:nq5mhr77"
@@ -26,6 +27,7 @@ final class EventGroupViewTests: XCTestCase {
         XCTAssertEqual(event_author_name(profiles: damusState.profiles, pubkey: ANON_PUBKEY), "Anonymous")
     }
 
+    @MainActor
     func testEventGroupUniquePubkeys() {
         let damusState = test_damus_state
 
@@ -48,6 +50,7 @@ final class EventGroupViewTests: XCTestCase {
         XCTAssertEqual(event_group_unique_pubkeys(profiles: damusState.profiles, group: .repost(EventGroup(events: [repost1, repost2, repost3]))), [pk1, pk2, pk3])
     }
 
+    @MainActor
     func testReactingToText() throws {
         let enUsLocale = Locale(identifier: "en-US")
         let damusState = test_damus_state

damusTests/Models/ContactCardManagerTests.swift

@@ -23,6 +23,7 @@ final class ContactCardManagerTests: XCTestCase {
         XCTAssertFalse(result)
     }
     
+    @MainActor
     func testIsFavorite_WhenPubkeyExists_ReturnsTrue() {
         // Given: A pubkey added to favorites
         let sut = ContactCardManager()
@@ -36,6 +37,7 @@ final class ContactCardManagerTests: XCTestCase {
         XCTAssertTrue(result)
     }
     
+    @MainActor
     func testIsFavorite_WhenPubkeyDoesNotExist_ReturnsFalse() {
         // Given: A different pubkey added to favorites
         let sut = ContactCardManager()
@@ -50,6 +52,7 @@ final class ContactCardManagerTests: XCTestCase {
         XCTAssertFalse(result)
     }
 
+    @MainActor
     func testToggleFavorite_WhenNotFavorite_AddsToFavorites() {
         // Given: A pubkey not in favorites
         let sut = ContactCardManager()
@@ -64,6 +67,7 @@ final class ContactCardManagerTests: XCTestCase {
         XCTAssertEqual(sut.favorites.count, 1)
     }
     
+    @MainActor
     func testToggleFavorite_WhenAlreadyFavorite_RemovesFromFavorites() {
         // Given: A pubkey already in favorites
         let sut = ContactCardManager()
@@ -105,6 +109,7 @@ final class ContactCardManagerTests: XCTestCase {
         XCTAssertTrue(sut.isFavorite(targetPubkey))
     }
 
+    @MainActor
     func testloadEvent_WithContactCard_RemovesFromFavorites() {
         // Given: A contact card event without favorite tag (unfavorite)
         let sut = ContactCardManager()
@@ -219,6 +224,7 @@ final class ContactCardManagerTests: XCTestCase {
         XCTAssertTrue(sut.isFavorite(targetPubkey))
     }
 
+    @MainActor
     func testFilter_WithFavoritePubkey_ReturnsTrue() {
         // Given: A pubkey in favorites
         let sut = ContactCardManager()

damusTests/MutingTests.swift

@@ -10,6 +10,7 @@ import XCTest
 @testable import damus
 
 final class MutingTests: XCTestCase {
+    @MainActor
     func testWordMuting() async {
         // Setup some test data
         let test_note = NostrEvent(

damusTests/NoteContentViewTests.swift

@@ -344,6 +344,7 @@ class NoteContentViewTests: XCTestCase {
     
     /// Quick test that exercises the direct parsing methods (i.e. not fetching blocks from nostrdb) from `NdbBlockGroup`, and its bridging code with C.
     /// The parsing logic itself already has test coverage at the nostrdb level.
+    @MainActor
     func testDirectBlockParsing() {
         let kp = test_keypair_full
         let dm: NdbNote = NIP04.create_dm("Test", to_pk: kp.pubkey, tags: [], keypair: kp.to_keypair())!
@@ -360,24 +361,28 @@ class NoteContentViewTests: XCTestCase {
         })
     }
     
+    @MainActor
     func testMentionStr_Pubkey_ContainsAbbreviated() throws {
         let compatibleText = createCompatibleText(test_pubkey.npub)
         
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: "17ldvg64:nq5mhr77")
     }
     
+    @MainActor
     func testMentionStr_Pubkey_ContainsFullBech32() {
         let compatableText = createCompatibleText(test_pubkey.npub)
 
         assertCompatibleTextHasExpectedString(compatibleText: compatableText, expected: test_pubkey.npub)
     }
     
+    @MainActor
     func testMentionStr_Nprofile_ContainsAbbreviated() throws {
         let compatibleText = createCompatibleText("nprofile1qqsrhuxx8l9ex335q7he0f09aej04zpazpl0ne2cgukyawd24mayt8gpp4mhxue69uhhytnc9e3k7mgpz4mhxue69uhkg6nzv9ejuumpv34kytnrdaksjlyr9p")
                 
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: "180cvv07:wsyjh6w6")
     }
     
+    @MainActor
     func testMentionStr_Nprofile_ContainsFullBech32() throws {
         let bech = "nprofile1qqsrhuxx8l9ex335q7he0f09aej04zpazpl0ne2cgukyawd24mayt8gpp4mhxue69uhhytnc9e3k7mgpz4mhxue69uhkg6nzv9ejuumpv34kytnrdaksjlyr9p"
         let compatibleText = createCompatibleText(bech)
@@ -385,18 +390,21 @@ class NoteContentViewTests: XCTestCase {
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: bech)
     }
     
+    @MainActor
     func testMentionStr_Note_ContainsAbbreviated() {
         let compatibleText = createCompatibleText(test_note.id.bech32)
 
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: "note1qqq:qqn2l0z3")
     }
     
+    @MainActor
     func testMentionStr_Note_ContainsFullBech32() {
         let compatibleText = createCompatibleText(test_note.id.bech32)
 
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: test_note.id.bech32)
     }
     
+    @MainActor
     func testMentionStr_Nevent_ContainsAbbreviated() {
         let bech = "nevent1qqstna2yrezu5wghjvswqqculvvwxsrcvu7uc0f78gan4xqhvz49d9spr3mhxue69uhkummnw3ez6un9d3shjtn4de6x2argwghx6egpr4mhxue69uhkummnw3ez6ur4vgh8wetvd3hhyer9wghxuet5nxnepm"
         let compatibleText = createCompatibleText(bech)
@@ -404,6 +412,7 @@ class NoteContentViewTests: XCTestCase {
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: "nevent1q:t5nxnepm")
     }
     
+    @MainActor
     func testMentionStr_Nevent_ContainsFullBech32() throws {
         let bech = "nevent1qqstna2yrezu5wghjvswqqculvvwxsrcvu7uc0f78gan4xqhvz49d9spr3mhxue69uhkummnw3ez6un9d3shjtn4de6x2argwghx6egpr4mhxue69uhkummnw3ez6ur4vgh8wetvd3hhyer9wghxuet5nxnepm"
         let compatibleText = createCompatibleText(bech)
@@ -411,6 +420,7 @@ class NoteContentViewTests: XCTestCase {
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: bech)
     }
     
+    @MainActor
     func testMentionStr_Naddr_ContainsAbbreviated() {
         let bech = "naddr1qqxnzdesxqmnxvpexqunzvpcqyt8wumn8ghj7un9d3shjtnwdaehgu3wvfskueqzypve7elhmamff3sr5mgxxms4a0rppkmhmn7504h96pfcdkpplvl2jqcyqqq823cnmhuld"
         let compatibleText = createCompatibleText(bech)
@@ -418,6 +428,7 @@ class NoteContentViewTests: XCTestCase {
         assertCompatibleTextHasExpectedString(compatibleText: compatibleText, expected: "naddr1qq:3cnmhuld")
     }
     
+    @MainActor
     func testMentionStr_Naddr_ContainsFullBech32() {
         let bech = "naddr1qqxnzdesxqmnxvpexqunzvpcqyt8wumn8ghj7un9d3shjtnwdaehgu3wvfskueqzypve7elhmamff3sr5mgxxms4a0rppkmhmn7504h96pfcdkpplvl2jqcyqqq823cnmhuld"
         let compatibleText = createCompatibleText(bech)
@@ -436,6 +447,7 @@ private func assertCompatibleTextHasExpectedString(compatibleText: CompatibleTex
     XCTAssertTrue(hasExpected)
 }
 
+@MainActor
 private func createCompatibleText(_ bechString: String) -> CompatibleText {
     guard let mentionRef = Bech32Object.parse(bechString)?.toMentionRef() else {
         XCTFail("Failed to create MentionRef from Bech32 string")

damusTests/RepostedTests.swift

@@ -10,6 +10,7 @@ import XCTest
 
 final class RepostedTests: XCTestCase {
 
+    @MainActor
     func testPeopleRepostedText() throws {
         let enUsLocale = Locale(identifier: "en-US")
         let damusState = test_damus_state

damusTests/WalletConnectTests.swift

@@ -94,8 +94,9 @@ final class WalletConnectTests: XCTestCase {
         XCTAssertEqual(pool.all_descriptors.count, 1)
         XCTAssertEqual(pool.all_descriptors[0].variant, .nwc)
         XCTAssertEqual(pool.all_descriptors[0].url.url.absoluteString, "ws://127.0.0.1")
-        XCTAssertEqual(box.events.count, 1)
-        let ev = box.events.first!.value
+        let boxEventCount = await box.events.count
+        XCTAssertEqual(boxEventCount, 1)
+        let ev = await box.events.first!.value
         XCTAssertEqual(ev.skip_ephemeral, false)
         XCTAssertEqual(ev.remaining.count, 1)
         XCTAssertEqual(ev.remaining[0].relay.url.absoluteString, "ws://127.0.0.1")

damusTests/ZapTests.swift

@@ -17,6 +17,7 @@ final class ZapTests: XCTestCase {
         // Put teardown code here. This method is called after the invocation of each test method in the class.
     }
 
+    @MainActor
     func test_alby_zap() throws {
         let zapjson = "eyJjb250ZW50Ijoi4pqhTm9uLWN1c3RvZGlhbCB6YXAgZnJvbSBteSBBbGJ5IEh1YiIsImNyZWF0ZWRfYXQiOjE3MjQ2ODUwNDcsImlkIjoiNGM3NWFiMWU3MDk4Y2NiN2FlYjhmZjdkNDIwMjM2ZDM1N2U1OGNjZmI3OWZiZTEwMTcwNGNiMzY0OTg3YjY4YSIsImtpbmQiOjk3MzUsInB1YmtleSI6Ijc5ZjAwZDNmNWExOWVjODA2MTg5ZmNhYjAzYzFiZTRmZjgxZDE4ZWU0ZjY1M2M4OGZhYzQxZmUwMzU3MGY0MzIiLCJzaWciOiI3OWM5ZDJjN2ExZWI1NmNhZjMyOTY1ZTRkMDJlYjJiYjFmYTY3NGViMDM4ZWE2MmFjZTg2YzBiMzA2OTJhMjU0YWU0M2JhNmMzNjcyMDJkZjgxNzQ5NGNhNTg4NzRkNWI1OWMxY2VhMDdjZTk5Mjk0MmIyOWYwZmVlZmJlM2FiZCIsInRhZ3MiOltbInAiLCIxNWI1Y2Y2Y2RmNGZkMWMwMmYyOGJjY2UwZjE5N2NhZmFlNGM4YzdjNjZhM2UyZTIzYWY5ZmU2MTA4NzUzMTVlIl0sWyJlIiwiYmNiMmZjZmUxYzQ2N2M1ZWM4Mjg1ZTM4NWMzNmVjMTM4Nzk3MDljZWQ5ZDg4MDBjYjM0MGViZjIxOGMzMjEwZCJdLFsiUCIsIjA1MjFkYjk1MzEwOTZkZmY3MDBkY2Y0MTBiMDFkYjQ3YWI2NTk4ZGU3ZTVlZjJjNWEyYmQ3ZTExNjAzMTViZjYiXSxbImJvbHQxMSIsImxuYmMxMHUxcG52ZXhoM2RwdXUyZDJ6bm4wZGNra3hhdG53M2hrZzZ0cGRzczg1Y3RzeXBuOHltbWR5cGtoamd6cGQzMzhqZ3pndzQzcW5wNHEyMjhhMnp0eGt3emF5cHZ6cnNoODIzcW5nbXY5N2YydjlwdXd2dHNhZGV0eXBtdXR5c2N3cHA1dmxjbGwwMHpwcGhoMzJ3OHV0NWpwcDVhMmZtcWg4c3o3bnUyaDd2MDdyMHU1bHN3ZzVsc3NwNXh2YXFlZnpsY2t6bXYwdzg5bHIwazB5dnI1eGQybmc1MmE1cmNkYXJmbTRmMGEwd2dwdXE5cXl5c2dxY3FwY3hxeXo1dnFlcHMzOXNleDUyc2ZtdHU5Z25tNWRhcGs1bGdsZDRwcDk2dXI1YTRhbTk0MHEyNXd6ZHNycmo1MjN4eWEwcnV4YTVscjk2M2cwMjk2cjZtZGZ5MjR2NjUzZXZjcHh5cjBtbWhnd21zcXh2cmhmZCJdLFsicHJlaW1hZ2UiLCJhZDA0N2MwMmZlNWYwNTljODA4NzdkNzk0YmU4OGU0N2M2NDRlYmVkZmRmZTY2M2IyODljOTMxNmRiNDk1ZjJkIl0sWyJkZXNjcmlwdGlvbiIsIntcImtpbmRcIjo5NzM0LFwiY3JlYXRlZF9hdFwiOjE3MjQ2ODUwMzgsXCJjb250ZW50XCI6XCLimqFOb24tY3VzdG9kaWFsIHphcCBmcm9tIG15IEFsYnkgSHViXCIsXCJ0YWdzXCI6W1tcInBcIixcIjE1YjVjZjZjZGY0ZmQxYzAyZjI4YmNjZTBmMTk3Y2FmYWU0YzhjN2M2NmEzZTJlMjNhZjlmZTYxMDg3NTMxNWVcIl0sW1wicmVsYXlzXCIsXCJ3c3M6Ly9wdXJwbGVwYWcuZXMvXCIsXCJ3c3M6Ly9yZWxheS5nZXRhbGJ5LmNvbS92MVwiLFwid3NzOi8vbm9zdHIubW9tL1wiLFwid3NzOi8vbm9zdHIub3h0ci5kZXYvXCIsXCJ3c3M6Ly9ub3MubG9sL1wiLFwid3NzOi8vbm9zdHIud2luZS9cIixcIndzczovL3JlbGF5LmRhbXVzLmlvL1wiLFwid3NzOi8vcmVsYXkubm90b3NoaS53aW4vXCIsXCJ3c3M6Ly9lZGVuLm5vc3RyLmxhbmQvXCJdLFtcImFtb3VudFwiLFwiMTAwMDAwMFwiXSxbXCJlXCIsXCJiY2IyZmNmZTFjNDY3YzVlYzgyODVlMzg1YzM2ZWMxMzg3OTcwOWNlZDlkODgwMGNiMzQwZWJmMjE4YzMyMTBkXCJdXSxcInB1YmtleVwiOlwiMDUyMWRiOTUzMTA5NmRmZjcwMGRjZjQxMGIwMWRiNDdhYjY1OThkZTdlNWVmMmM1YTJiZDdlMTE2MDMxNWJmNlwiLFwiaWRcIjpcIjU3ZDg2MTIwMDc1MjFjMGI1MzJiOTFhZjI0OTgwOTVhMjUxZTYzZjQyNTE4N2U2Yzk1NzAwZmQwYTZiYWI3ZDRcIixcInNpZ1wiOlwiNzk4ZDczNTExOGJjZDE0MjI4YTEyYjZkNTI0MjNmZjI1YmI0ZWQ4Y2Q1ZGFjZjJmNTk3MWVmNTczZmRjM2ZjMDVmYzc5MzE4NWU2OTY4MmNjYTI0M2Q2NGYxNDdhNDQ5ODk2OGEwYmMyODhhZTgzZTc1YzAzZTk5ZjkzNmE2MDNcIn0iXV19Cg=="
 
@@ -75,6 +76,7 @@ final class ZapTests: XCTestCase {
         XCTAssertEqual(message, decrypted.content)
     }
     
+    @MainActor
     func testZap() throws {
         let zapjson = "eyJpZCI6IjUzNmJlZTllODNjODE4ZTNiODJjMTAxOTM1MTI4YWUyN2EwZDQyOTAwMzlhYWYyNTNlZmU1ZjA5MjMyYzE5NjIiLCJwdWJrZXkiOiI5NjMwZjQ2NGNjYTZhNTE0N2FhOGEzNWYwYmNkZDNjZTQ4NTMyNGU3MzJmZDM5ZTA5MjMzYjFkODQ4MjM4ZjMxIiwiY3JlYXRlZF9hdCI6MTY3NDIwNDUzNSwia2luZCI6OTczNSwidGFncyI6W1sicCIsIjMyZTE4Mjc2MzU0NTBlYmIzYzVhN2QxMmMxZjhlN2IyYjUxNDQzOWFjMTBhNjdlZWYzZDlmZDljNWM2OGUyNDUiXSxbImJvbHQxMSIsImxuYmMxMHUxcDN1NTR0bnNwNTcyOXF2eG5renRqamtkNTg1eW4wbDg2MzBzMm01eDZsNTZ3eXk0ZWMybnU4eHV6NjI5eHFwcDV2MnE3aHVjNGpwamgwM2Z4OHVqZXQ1Nms3OWd4cXg3bWUycGV2ejZqMms4dDhtNGxnNXZxaHA1eWc1MDU3OGNtdWoyNG1mdDNxcnNybWd3ZjMwa2U3YXY3ZDc3Z2FtZmxkazlrNHNmMzltcXhxeWp3NXFjcXBqcnpqcTJoeWVoNXEzNmx3eDZ6dHd5cmw2dm1tcnZ6NnJ1ZndqZnI4N3lremZuYXR1a200dWRzNHl6YWszc3FxOW1jcXFxcXFxcWxncXFxcTg2cXF5ZzlxeHBxeXNncWFkeWVjdmR6ZjI3MHBkMzZyc2FmbDA3azQ1ZmNqMnN5OGU1djJ0ZW5kNTB2OTU3NnV4cDNkdmp6amV1aHJlODl5cGdjbTkwZDZsbTAwNGszMHlqNGF2NW1jc3M1bnl4NHU5bmVyOWdwcHY2eXF3Il0sWyJkZXNjcmlwdGlvbiIsIntcImlkXCI6XCJiMDkyMTYzNGIxYmI4ZWUzNTg0YmJiZjJlOGQ3OTBhZDk4NTk5ZDhlMDhmODFjNzAwZGRiZTQ4MjAxNTY4Yjk3XCIsXCJwdWJrZXlcIjpcIjdmYTU2ZjVkNjk2MmFiMWUzY2Q0MjRlNzU4YzMwMDJiODY2NWY3YjBkOGRjZWU5ZmU5ZTI4OGQ3NzUxYWMxOTRcIixcImNyZWF0ZWRfYXRcIjoxNjc0MjA0NTMxLFwia2luZFwiOjk3MzQsXCJ0YWdzXCI6W1tcInBcIixcIjMyZTE4Mjc2MzU0NTBlYmIzYzVhN2QxMmMxZjhlN2IyYjUxNDQzOWFjMTBhNjdlZWYzZDlmZDljNWM2OGUyNDVcIl0sW1wicmVsYXlzXCIsXCJ3c3M6Ly9yZWxheS5zbm9ydC5zb2NpYWxcIixcIndzczovL3JlbGF5LmRhbXVzLmlvXCIsXCJ3c3M6Ly9ub3N0ci1wdWIud2VsbG9yZGVyLm5ldFwiLFwid3NzOi8vbm9zdHIudjBsLmlvXCIsXCJ3c3M6Ly9wcml2YXRlLW5vc3RyLnYwbC5pb1wiLFwid3NzOi8vbm9zdHIuemViZWRlZS5jbG91ZFwiLFwid3NzOi8vcmVsYXkubm9zdHIuaW5mby9cIl1dLFwiY29udGVudFwiOlwiXCIsXCJzaWdcIjpcImQwODQwNGU2MjVmOWM1NjMzYWZhZGQxMWMxMTBiYTg4ZmNkYjRiOWUwOTJiOTg0MGU3NDgyYThkNTM3YjFmYzExODY5MmNmZDEzMWRkODMzNTM2NDc2OWE2NzE3NTRhZDdhYTk3MzEzNjgzYTRhZDdlZmI3NjQ3NmMwNGU1ZjE3XCJ9Il0sWyJwcmVpbWFnZSIsIjNlMDJhM2FmOGM4YmNmMmEzNzUzYzg3ZjMxMTJjNjU2YTIwMTE0ZWUwZTk4ZDgyMTliYzU2ZjVlOGE3MjM1YjMiXV0sImNvbnRlbnQiOiIiLCJzaWciOiIzYWI0NGQwZTIyMjhiYmQ0ZDIzNDFjM2ZhNzQwOTZjZmY2ZjU1Y2ZkYTk5YTVkYWRjY2Y0NWM2NjQ2MzdlMjExNTFiMmY5ZGQwMDQwZjFhMjRlOWY4Njg2NzM4YjE2YmY4MTM0YmRiZTQxYTIxOGM5MTFmN2JiMzFlNTk1NzhkMSJ9Cg=="