tyiu/damus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reaction events to not tag all e and p tags in the thread

Browse Source 
Changelog-Fixed: Fix reaction events to not tag all e and p tags in the thread
This commit is contained in:
Terry Yiu
2024-06-05 18:40:22 -04:00
parent 2c84184dbd
commit 5ff352361c
4 changed files with 43 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
damusTests/LikeTests.swift
View File

@@ -10,15 +10,7 @@ import XCTest
class LikeTests: XCTestCase {
override func setUpWithError() throws {
// Put setup code here. This method is called before the invocation of each test method in the class.
}
override func tearDownWithError() throws {
// Put teardown code here. This method is called after the invocation of each test method in the class.
}
func testLikeHasNotification() throws {
func testReactionTextNote() throws {
let cindy = Pubkey(hex: "9d9181f0aea6500e1f360e07b9f37e25c72169b5158ae78df53f295272b6b71c")!
let bob = Pubkey(hex: "218837fe8c94a66ae33af277bcbda45a0319e7726220cd76171b9dd1a468af91")!
let liked = NostrEvent(content: "awesome #[0] post",
@@ -28,9 +20,30 @@ class LikeTests: XCTestCase {
let like_ev = make_like_event(keypair: test_keypair_full, liked: liked)!
XCTAssertTrue(like_ev.referenced_pubkeys.contains(test_keypair.pubkey))
XCTAssertTrue(like_ev.referenced_pubkeys.contains(cindy))
XCTAssertTrue(like_ev.referenced_pubkeys.contains(bob))
XCTAssertFalse(like_ev.referenced_pubkeys.contains(cindy))
XCTAssertFalse(like_ev.referenced_pubkeys.contains(bob))
XCTAssertEqual(like_ev.last_refid()!, id)
XCTAssertTrue(like_ev.tags.allSatisfy { !$0[0].matches_char("a") })
let kindTag = try XCTUnwrap(like_ev.tags.first(where: { $0.count >= 2 && $0[0].matches_char("k") }))
XCTAssertTrue(kindTag[1].matches_str("1"))
}
func testReactionLongFormNote() throws {
let liked = test_longform_event.event
let id = liked.id
let like_ev = make_like_event(keypair: test_keypair_full, liked: liked)!
XCTAssertTrue(like_ev.referenced_pubkeys.contains(test_keypair.pubkey))
XCTAssertEqual(like_ev.last_refid()!, id)
let dTagValue = try XCTUnwrap(liked.tags.first { $0[0].matches_char("d") })
let aTag = try XCTUnwrap(like_ev.tags.first { $0[0].matches_char("a") })
XCTAssertTrue(aTag[1].matches_str("30023:\(test_keypair.pubkey.hex()):\(dTagValue[1])"))
let kindTag = try XCTUnwrap(like_ev.tags.first(where: { $0.count >= 2 && $0[0].matches_char("k") }))
// FIXME(tyiu) the assertion below fails for some reason even though in a different test, I was able to assert kind 1 just fine.
// XCTAssertTrue(kindTag[1].matches_str("30023"))
}
func testToReactionEmoji() {