From 48d3049f3f7055cf97353ba897664201b4a25c86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20D=E2=80=99Aquino?= Date: Fri, 14 Nov 2025 17:39:57 -0800 Subject: [PATCH] Improve accessibility and localization support on Damus Labs screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note: This is an improvement on an unreleased feature, so no changelog entry is needed. Changelog-None Signed-off-by: Daniel D’Aquino --- damus/Features/Labs/Views/DamusLabsExperiments.swift | 7 ++++--- damus/Features/Labs/Views/Detail/LabsLogoView.swift | 5 +++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/damus/Features/Labs/Views/DamusLabsExperiments.swift b/damus/Features/Labs/Views/DamusLabsExperiments.swift index a4b733cc..9acbf359 100644 --- a/damus/Features/Labs/Views/DamusLabsExperiments.swift +++ b/damus/Features/Labs/Views/DamusLabsExperiments.swift @@ -44,27 +44,28 @@ struct DamusLabsExperiments: View { LabsToggleView(toggleName: live_label, systemImage: "record.circle", isOn: $settings.live, showInfo: $show_live_explainer) LabsToggleView(toggleName: favorites_label, systemImage: "heart.fill", isOn: $settings.enable_favourites_feature, showInfo: $show_favorites_explainer) + } .padding([.trailing, .leading], 20) .padding(.bottom, 50) Image("damooseLabs") .resizable() + .accessibilityHidden(true) .aspectRatio(contentMode: .fill) - } .ignoresSafeArea(edges: .bottom) .sheet(isPresented: $show_live_explainer) { LabsExplainerView( labName: live_label, systemImage: "record.circle", - labDescription: "This will allow you to see all the real-time live streams happening on Nostr! As well as let you view and interact in the Live Chat. Please keep in mind this is still a work in progress and issues are expected. When enabled you will see the Live option in your side menu.") + labDescription: NSLocalizedString("This will allow you to see all the real-time live streams happening on Nostr! As well as let you view and interact in the Live Chat. Please keep in mind this is still a work in progress and issues are expected. When enabled you will see the Live option in your side menu.", comment: "Damus Labs feature explanation")) } .sheet(isPresented: $show_favorites_explainer) { LabsExplainerView( labName: favorites_label, systemImage: "heart.fill", - labDescription: "This will allow you to pick users to be part of your favorites list. You can also switch your profile timeline to only see posts from your favorite contacts.") + labDescription: NSLocalizedString("This will allow you to pick users to be part of your favorites list. You can also switch your profile timeline to only see posts from your favorite contacts.", comment: "Damus Labs feature explanation")) } } } diff --git a/damus/Features/Labs/Views/Detail/LabsLogoView.swift b/damus/Features/Labs/Views/Detail/LabsLogoView.swift index 44e10e71..ade39dd1 100644 --- a/damus/Features/Labs/Views/Detail/LabsLogoView.swift +++ b/damus/Features/Labs/Views/Detail/LabsLogoView.swift @@ -22,6 +22,7 @@ struct LabsLogoView: View { endPoint: .bottomTrailing), lineWidth: 1) ) .shadow(radius: 5) + .accessibilityHidden(true) VStack(alignment: .leading) { HStack(spacing: 0) { @@ -29,6 +30,7 @@ struct LabsLogoView: View { .font(.system(size: 60.0).weight(.bold)) .foregroundColor(.white) .tracking(-2) + .accessibilityHidden(true) Image(systemName: "flask.fill") .padding(.top, 25) .foregroundStyle( @@ -38,6 +40,7 @@ struct LabsLogoView: View { endPoint: .bottomTrailing ) ) + .accessibilityHidden(true) Image(systemName: "testtube.2") .padding(.top, 25) .foregroundStyle( @@ -47,10 +50,12 @@ struct LabsLogoView: View { endPoint: .topTrailing ) ) + .accessibilityHidden(true) } } } .padding(.bottom, 30) + .accessibilityLabel(NSLocalizedString("Damus Labs stylized logo", comment: "Accessibility label for a stylized Damus Labs logo")) } }