Swift cleanup: remove duplicate or unnecessary initializers using default values

Signed-off-by: Bryan Montz <bryanmontz@me.com>
Signed-off-by: William Casarin <jb55@jb55.com>

damus/Models/ActionBarModel.swift

@@ -28,19 +28,7 @@ class ActionBarModel: ObservableObject {
         return ActionBarModel(likes: 0, boosts: 0, zaps: 0, zap_total: 0, replies: 0, our_like: nil, our_boost: nil, our_zap: nil, our_reply: nil)
     }
     
-    init() {
-        self.our_like = nil
-        self.our_boost = nil
-        self.our_reply = nil
-        self.our_zap = nil
-        self.likes = 0
-        self.boosts = 0
-        self.zaps = 0
-        self.zap_total = 0
-        self.replies = 0
-    }
-    
-    init(likes: Int, boosts: Int, zaps: Int, zap_total: Int64, replies: Int, our_like: NostrEvent?, our_boost: NostrEvent?, our_zap: Zapping?, our_reply: NostrEvent?) {
+    init(likes: Int = 0, boosts: Int = 0, zaps: Int = 0, zap_total: Int64 = 0, replies: Int = 0, our_like: NostrEvent? = nil, our_boost: NostrEvent? = nil, our_zap: Zapping? = nil, our_reply: NostrEvent? = nil) {
         self.likes = likes
         self.boosts = boosts
         self.zaps = zaps

damus/Models/CreateAccountModel.swift

@@ -35,13 +35,7 @@ class CreateAccountModel: ObservableObject {
         return Keypair(pubkey: self.pubkey, privkey: self.privkey)
     }
     
-    init() {
-        let keypair = generate_new_keypair()
-        self.pubkey = keypair.pubkey
-        self.privkey = keypair.privkey!
-    }
-    
-    init(real: String, nick: String, about: String) {
+    init(real: String = "", nick: String = "", about: String = "") {
         let keypair = generate_new_keypair()
         self.pubkey = keypair.pubkey
         self.privkey = keypair.privkey!

damus/Models/DirectMessageModel.swift

@@ -14,11 +14,11 @@ class DirectMessageModel: ObservableObject {
         }
     }
 
-    @Published var draft: String
+    @Published var draft: String = ""
     
     let pubkey: String
     
-    var is_request: Bool
+    var is_request = false
     var our_pubkey: String
     
     func determine_is_request() -> Bool {
@@ -31,19 +31,9 @@ class DirectMessageModel: ObservableObject {
         return true
     }
     
-    init(events: [NostrEvent], our_pubkey: String, pubkey: String) {
+    init(events: [NostrEvent] = [], our_pubkey: String, pubkey: String) {
         self.events = events
-        self.is_request = false
         self.our_pubkey = our_pubkey
-        self.draft = ""
-        self.pubkey = pubkey
-    }
-    
-    init(our_pubkey: String, pubkey: String) {
-        self.events = []
-        self.is_request = false
-        self.our_pubkey = our_pubkey
-        self.draft = ""
         self.pubkey = pubkey
     }
 }

damus/Models/DraftsModel.swift

@@ -11,12 +11,7 @@ class DraftArtifacts {
     var content: NSMutableAttributedString
     var media: [UploadedMedia]
     
-    init() {
-        self.content = NSMutableAttributedString(string: "")
-        self.media = []
-    }
-    
-    init(content: NSMutableAttributedString, media: [UploadedMedia]) {
+    init(content: NSMutableAttributedString = NSMutableAttributedString(string: ""), media: [UploadedMedia] = []) {
         self.content = content
         self.media = media
     }

damus/Models/Notifications/EventGroup.swift

@@ -18,11 +18,7 @@ class EventGroup {
         return first.created_at
     }
     
-    init() {
-        self.events = []
-    }
-    
-    init(events: [NostrEvent]) {
+    init(events: [NostrEvent] = []) {
         self.events = events
     }
     

damus/Models/Notifications/ZapGroup.swift

@@ -8,9 +8,9 @@
 import Foundation
 
 class ZapGroup {
-    var zaps: [Zapping]
-    var msat_total: Int64
-    var zappers: Set<String>
+    var zaps: [Zapping] = []
+    var msat_total: Int64 = 0
+    var zappers = Set<String>()
     
     var last_event_at: Int64 {
         guard let first = zaps.first else {
@@ -46,12 +46,6 @@ class ZapGroup {
         return grp
     }
     
-    init() {
-        self.zaps = []
-        self.msat_total = 0
-        self.zappers = Set()
-    }
-    
     @discardableResult
     func insert(_ zap: Zapping) -> Bool {
         if !insert_uniq_sorted_zap_by_created(zaps: &zaps, new_zap: zap) {

damus/Models/NotificationsModel.swift

@@ -99,34 +99,20 @@ enum NotificationItem {
 }
 
 class NotificationsModel: ObservableObject, ScrollQueue {
-    var incoming_zaps: [Zapping]
-    var incoming_events: [NostrEvent]
-    var should_queue: Bool
+    var incoming_zaps: [Zapping] = []
+    var incoming_events: [NostrEvent] = []
+    var should_queue: Bool = true
     
     // mappings from events to
-    var zaps: [String: ZapGroup]
-    var profile_zaps: ZapGroup
-    var reactions: [String: EventGroup]
-    var reposts: [String: EventGroup]
-    var replies: [NostrEvent]
-    var has_reply: Set<String>
-    var has_ev: Set<String>
+    var zaps: [String: ZapGroup] = [:]
+    var profile_zaps = ZapGroup()
+    var reactions: [String: EventGroup] = [:]
+    var reposts: [String: EventGroup] = [:]
+    var replies: [NostrEvent] = []
+    var has_reply = Set<String>()
+    var has_ev = Set<String>()
     
-    @Published var notifications: [NotificationItem]
-    
-    init() {
-        self.zaps = [:]
-        self.reactions = [:]
-        self.reposts = [:]
-        self.replies = []
-        self.has_reply = Set()
-        self.should_queue = true
-        self.incoming_zaps = []
-        self.incoming_events = []
-        self.profile_zaps = ZapGroup()
-        self.notifications = []
-        self.has_ev = Set()
-    }
+    @Published var notifications: [NotificationItem] = []
     
     func set_should_queue(_ val: Bool) {
         self.should_queue = val

damus/Models/SignalModel.swift

@@ -12,12 +12,7 @@ class SignalModel: ObservableObject {
     @Published var signal: Int
     @Published var max_signal: Int
     
-    init() {
-        self.signal = 0
-        self.max_signal = 0
-    }
-    
-    init(signal: Int, max_signal: Int) {
+    init(signal: Int = 0, max_signal: Int = 0) {
         self.signal = signal
         self.max_signal = max_signal
     }