From 073feccbbfc02231b49df39efdd8849b15f2a988 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20D=E2=80=99Aquino?= Date: Mon, 7 Jul 2025 16:47:28 -0700 Subject: [PATCH] CI: Fix UI tests to include new onboarding steps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changelog-None Closes: https://github.com/damus-io/damus/issues/3124 Signed-off-by: Daniel D’Aquino --- damus/Views/AppAccessibilityIdentifiers.swift | 9 +++++++++ damus/Views/Onboarding/InterestSelectionView.swift | 2 ++ damus/Views/Onboarding/OnboardingContentSettings.swift | 1 + damusUITests/damusUITests.swift | 3 +++ 4 files changed, 15 insertions(+) diff --git a/damus/Views/AppAccessibilityIdentifiers.swift b/damus/Views/AppAccessibilityIdentifiers.swift index 817ef7f5..b5eceee0 100644 --- a/damus/Views/AppAccessibilityIdentifiers.swift +++ b/damus/Views/AppAccessibilityIdentifiers.swift @@ -28,6 +28,15 @@ enum AppAccessibilityIdentifiers: String { // MARK: Onboarding // Prefix: `onboarding` + /// Any interest option button on the "select your interests" page during onboarding + case onboarding_interest_option_button + + /// The "next" button on the onboarding interest page + case onboarding_interest_page_next_page + + /// The "next" button on the onboarding content settings page + case onboarding_content_settings_page_next_page + /// The skip button on the onboarding sheet case onboarding_sheet_skip_button diff --git a/damus/Views/Onboarding/InterestSelectionView.swift b/damus/Views/Onboarding/InterestSelectionView.swift index 0ff5a75b..7d64c112 100644 --- a/damus/Views/Onboarding/InterestSelectionView.swift +++ b/damus/Views/Onboarding/InterestSelectionView.swift @@ -52,6 +52,7 @@ extension OnboardingSuggestionsView { .disabled(!isNextEnabled) .opacity(isNextEnabled ? 1.0 : 0.5) .padding([.leading, .trailing, .bottom]) + .accessibilityIdentifier(AppAccessibilityIdentifiers.onboarding_interest_page_next_page.rawValue) } .padding() } @@ -82,6 +83,7 @@ extension OnboardingSuggestionsView { selectedInterests.insert(interest) } } + .accessibilityIdentifier(AppAccessibilityIdentifiers.onboarding_interest_option_button.rawValue) .disabled(disabled) .opacity(disabled ? 0.5 : 1.0) } diff --git a/damus/Views/Onboarding/OnboardingContentSettings.swift b/damus/Views/Onboarding/OnboardingContentSettings.swift index 794297a4..dc1e4d46 100644 --- a/damus/Views/Onboarding/OnboardingContentSettings.swift +++ b/damus/Views/Onboarding/OnboardingContentSettings.swift @@ -74,6 +74,7 @@ extension OnboardingSuggestionsView { .disabled(!isNextEnabled) .opacity(isNextEnabled ? 1.0 : 0.5) .padding([.leading, .trailing, .bottom]) + .accessibilityIdentifier(AppAccessibilityIdentifiers.onboarding_content_settings_page_next_page.rawValue) } .padding() } diff --git a/damusUITests/damusUITests.swift b/damusUITests/damusUITests.swift index b23ee0e3..d1edb9e0 100644 --- a/damusUITests/damusUITests.swift +++ b/damusUITests/damusUITests.swift @@ -62,6 +62,9 @@ class damusUITests: XCTestCase { try self.login() } + app.buttons[AID.onboarding_interest_option_button.rawValue].firstMatch.tapIfExists(timeout: 5) + app.buttons[AID.onboarding_interest_page_next_page.rawValue].tapIfExists(timeout: 5) + app.buttons[AID.onboarding_content_settings_page_next_page.rawValue].tapIfExists(timeout: 5) app.buttons[AID.onboarding_sheet_skip_button.rawValue].tapIfExists(timeout: 5) app.buttons[AID.post_composer_cancel_button.rawValue].tapIfExists(timeout: 5) }